Add some browser tests for net-internals

chrome/test/base/ui_test_utils.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_UI_TEST_UTILS_H_
 #define CHROME_TEST_BASE_UI_TEST_UTILS_H_
 #pragma once
 
 #include <map>
 #include <queue>
@@ skipping 470 matching lines @@
   std::map<uintptr_t, U> details_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowedNotificationObserverWithDetails);
 };
 
 // Watches title changes on a tab, blocking until an expected title is set.
 class TitleWatcher : public NotificationObserver {
  public:
   // |tab_contents| must be non-NULL and needs to stay alive for the
   // entire lifetime of |this|. |expected_title| is the title that |this|
-  // will wait for.
-  TitleWatcher(TabContents* tab_contents, const string16& expected_title);
+  // will wait for.  If it's not an empty string, |this| will wait for
+  // |failure_title| is well.
+  TitleWatcher(TabContents* tab_contents, const string16& expected_title,
+               const string16& failure_title);
   virtual ~TitleWatcher();
 
-  // Waits until the title for the tab is set to the |expected_title|
-  // passed into the constructor.
+  // Waits until the title for the tab is set to the |expected_title| or
+  // |failure_title| passed into the constructor or one of the titles added with
+  // AddTitle.  Returns true if |expected_title| was seen, and false if
+  // |failure_title| was seen.  If both are seen, returns false, however, it's
+  // probably best not to rely of that to avoid any races.

[Paweł Hajdan Jr., 2011/08/02 20:19:16]

How about returning the last seen title when the message loop stopped? That
would be less error-prone.

[mmenke, 2011/08/02 21:04:40]

Sounds good to me.  Done.  Went ahead and switched to using a vector, so more
than two titles are allowed, though not sure if there's any use case where
that's useful.

   bool Wait() WARN_UNUSED_RESULT;
 
  private:
   // NotificationObserver
   virtual void Observe(int type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
   TabContents* expected_tab_;
   string16 expected_title_;
+  string16 failure_title_;
   NotificationRegistrar notification_registrar_;
-  bool title_observed_;
+  bool expected_title_observed_;
+  bool failure_title_observed_;
   bool quit_loop_on_observation_;
 
   DISALLOW_COPY_AND_ASSIGN(TitleWatcher);
 };
 
 // See SendKeyPressAndWait.  This function additionally performs a check on the
 // NotificationDetails using the provided Details<U>.
 template <class U>
 bool SendKeyPressAndWaitWithDetails(
     const Browser* browser,
@@ skipping 72 matching lines @@
 
 // Takes a snapshot of the entire page, according to the width and height
 // properties of the DOM's document. Returns true on success. DOMAutomation
 // must be enabled.
 bool TakeEntirePageSnapshot(RenderViewHost* rvh,
                             SkBitmap* bitmap) WARN_UNUSED_RESULT;
 
 }  // namespace ui_test_utils
 
 #endif  // CHROME_TEST_BASE_UI_TEST_UTILS_H_