Issue 7552042: ui_tests is needed by chromium performance testers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7552042: ui_tests is needed by chromium performance testers (Closed)

Created:
9 years, 4 months ago by M-A Ruel

Modified:
9 years, 4 months ago

Reviewers:
cmp, chase, Mattias Nissler (ping if slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ui_tests is needed by chromium performance testers TBR=chase@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96185

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Linux Builder builds the target chromium_builder_perf. http://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/19946/steps/compile/logs/stdio ui_tests is not generated, not archived, http://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/19946/steps/package_build/logs/stdio ui_tests ...

9 years, 4 months ago (2011-08-10 15:30:17 UTC) #1

cmp

9 years, 4 months ago (2011-08-10 17:31:26 UTC) #4

lgtm with nit

http://codereview.chromium.org/7552042/diff/1/build/all.gyp
File build/all.gyp (right):

http://codereview.chromium.org/7552042/diff/1/build/all.gyp#newcode278
build/all.gyp:278: '../chrome/chrome.gyp:ui_tests',
btw, these are supposed to remain in alphabetic order

Expand Messages | Collapse Messages