Issue 7552036: Fixed apps uninstall in NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7552036: Fixed apps uninstall in NTP. (Closed)

Created:
9 years, 4 months ago by Joao da Silva

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, James Hawkins, Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fixed apps uninstall in NTP. The new NTP (enabled from about:flags) doesn't have this issue. BUG=86543 TEST=Force install an app using the ExtensionInstallForcelist policy. The app shouldn't have the uninstall menu enabled on the NTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96357

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/ntp/apps.js	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Hi James! Just a small bug fix, please review & owner approve. Thanks!

9 years, 4 months ago (2011-08-10 12:12:23 UTC) #1

Change committed as 96357

Expand Messages | Collapse Messages