Issue 7552031: Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7552031: Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening ... (Closed)

Created:
9 years, 4 months ago by kerz_chromium

Modified:
9 years, 4 months ago

Reviewers:
caseq

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/

Visibility:
Public.

Description

Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector https://bugs.webkit.org/show_bug.cgi?id=65912 Reviewed by Pavel Feldman. * inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): TBR=caseq@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92740

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	Source/WebCore/ChangeLog	View		1 chunk	+38 lines, -0 lines	0 comments	Download
	M	Source/WebCore/inspector/InspectorDOMStorageAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

caseq

On 2011/08/10 07:46:18, caseq wrote: > On 2011/08/10 01:39:57, kerz_chromium wrote: > > LGTM One ...

9 years, 4 months ago (2011-08-10 07:48:01 UTC) #3

kerz_chromium

9 years, 4 months ago (2011-08-10 07:59:54 UTC) #4

ChangeLog is ignored on the branch, so no worries.

On Wed, Aug 10, 2011 at 12:48 AM, <caseq@chromium.org> wrote:

> On 2011/08/10 07:46:18, caseq wrote:
>
>> On 2011/08/10 01:39:57, kerz_chromium wrote:
>>
>
>  LGTM
>>
>
> One note, though -- there are two entries in the ChangeLog diff, second is
> unrelated.
>
>
>
http://codereview.chromium.**org/7552031/<http://codereview.chromium.org/7552...
>

Expand Messages | Collapse Messages