Fix GetNetworkList() for POSIX to cope with address-less interfaces.

Fix GetNetworkList() for POSIX to cope with address-less interfaces.

BUG=92274
TEST=Browser does not crash if Chromoting client is used to connect from a machine with at least one network interface with no IP address.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96261

[Sergey Ulanov, 2011-08-10 01:36:10]

LGTM. I think we need this merged in M14. Can you please open a bug for it?

[commit-bot: I haz the power, 2011-08-10 17:15:40]

Presubmit check for 7552030-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/base/net_util_posix.cc

[Wez, 2011-08-10 17:18:04]

wtc: Would you mind giving the rubber-stamp, please?

[wtc, 2011-08-10 19:29:02]

LGTM.  Please fix the bug and add the comment I requested
before checking this in.

http://codereview.chromium.org/7552030/diff/1/net/base/net_util_posix.cc
File net/base/net_util_posix.cc (right):

http://codereview.chromium.org/7552030/diff/1/net/base/net_util_posix.cc#newc...
net/base/net_util_posix.cc:80: continue;
Did you test this patch?  On line 78 you have already
dereferenced ifa->ifa_addr.  The null pointer test needs to
be done the first thing in the for loop's body.

Please also add a comment to explain why ifa->ifa_addr can
be NULL (it is a network interface with no IP address).

Just curious: in that case, does the ifa->ifa_name field
still contain the correct network interface name?

[wtc, 2011-08-10 19:32:22]

http://codereview.chromium.org/7552030/diff/1/net/base/net_util_posix.cc
File net/base/net_util_posix.cc (right):

http://codereview.chromium.org/7552030/diff/1/net/base/net_util_posix.cc#newc...
net/base/net_util_posix.cc:80: continue;
I checked the other two getifaddrs calls in net/base/net_util.cc.
They already have this null pointer test.