Injected CSS localization fix (see bug no.)

chrome/browser/extensions/user_script_master_unittest.cc

Index: chrome/browser/extensions/user_script_master_unittest.cc
diff --git a/chrome/browser/extensions/user_script_master_unittest.cc b/chrome/browser/extensions/user_script_master_unittest.cc
index 78c4c128eab6bd4050952073b715477687197c54..6f8a381e915ee8eafc9d9161156d421c29340be2 100644
--- a/chrome/browser/extensions/user_script_master_unittest.cc
+++ b/chrome/browser/extensions/user_script_master_unittest.cc
@@ -220,7 +220,11 @@ TEST_F(UserScriptMasterTest, SkipBOMAtTheBeginning) {
   UserScriptList user_scripts;
   user_scripts.push_back(user_script);
 
-  UserScriptMaster::ScriptReloader::LoadUserScripts(&user_scripts);
+  UserScriptMaster::ScriptReloader* script_reloader =
+      new UserScriptMaster::ScriptReloader(NULL);
+  script_reloader->AddRef();

[Mihai Parparita -not on Chrome, 2011/08/11 01:58:34]

Instead of having to manually call AddRef/Release, can you just make the
ScriptReloader instance be on the stack?

[adriansc, 2011/08/11 21:25:08]

ScriptReloader is derived from RefCountedThreadSafe which in turn derived from
RefCountedThreadSafeBase. The destructor of this class exits with error unless
reference count has at least once been positive during the lifetime of the
object (base/memory/ref_counted.h). When the reference count falls back to 0,
the memory is released. This is why I allocated on the heap.

+  script_reloader->LoadUserScripts(&user_scripts);
+  script_reloader->Release();
 
   EXPECT_EQ(content.substr(3),
             user_scripts[0].js_scripts()[0].GetContent().as_string());
@@ -239,7 +243,11 @@ TEST_F(UserScriptMasterTest, LeaveBOMNotAtTheBeginning) {
   UserScriptList user_scripts;
   user_scripts.push_back(user_script);
 
-  UserScriptMaster::ScriptReloader::LoadUserScripts(&user_scripts);
+  UserScriptMaster::ScriptReloader* script_reloader =
+      new UserScriptMaster::ScriptReloader(NULL);
+  script_reloader->AddRef();
+  script_reloader->LoadUserScripts(&user_scripts);
+  script_reloader->Release();
 
   EXPECT_EQ(content, user_scripts[0].js_scripts()[0].GetContent().as_string());
 }