Injected CSS localization fix (see bug no.)

chrome/common/extensions/extension_set.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_SET_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_SET_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 39 matching lines @@
   bool InSameExtent(const GURL& old_url, const GURL& new_url) const;
 
   // Look up an Extension object by id.
   const Extension* GetByID(const std::string& id) const;
 
   // Returns true if |url| should get extension api bindings and be permitted
   // to make api calls. Note that this is independent of what extension
   // permissions the given extension has been granted.
   bool ExtensionBindingsAllowed(const GURL& url) const;
 
+  // Populates map with the path and default locale for all extension IDs.
+  void GetExtensionsPathAndDefaultLocale(

[Nebojša Ćirić, 2011/08/10 20:38:57]

Do you need this method? Couldn't you just:

make_pair(extension->extension_path(), extension->default_locale())?

[adriansc, 2011/08/10 23:20:53]

This method fills in a map by repeatedly calling make_pair for all extension IDs
in the set. The underlying map that I use for collecting the data is private, so
in order to iterate through all IDs, I added a function.

+      std::map<std::string, std::pair<FilePath, std::string> >& info) const;

[Nebojša Ćirić, 2011/08/10 20:38:57]

You could typedef it here as ExtensionPathAndDefaultLocale and then use it in
the .cc file and in user_script file.

[adriansc, 2011/08/10 23:20:53]

Done.

+
  private:
   FRIEND_TEST_ALL_PREFIXES(ExtensionSetTest, ExtensionSet);
 
   // static
   typedef std::map<std::string, scoped_refptr<const Extension> > ExtensionMap;
   ExtensionMap extensions_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionSet);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_SET_H_