Enable SQLite's secure-delete at runtime so that

sql/connection.cc

Index: sql/connection.cc
diff --git a/sql/connection.cc b/sql/connection.cc
index 3f63301ace0115f30add936a3a0639ba52327b77..0f2df97f79b08bb9cf7bda12e803f6a73712e5e8 100644
--- a/sql/connection.cc
+++ b/sql/connection.cc
@@ -376,6 +376,12 @@ bool Connection::OpenInternal(const std::string& file_name) {
       NOTREACHED() << "Could not set cache size: " << GetErrorMessage();
   }
 
+  if (!ExecuteWithTimeout("PRAGMA secure_delete=ON", kBusyTimeout)) {
+    NOTREACHED() << "Could not enable secure_delete: " << GetErrorMessage();

[Scott Hess - ex-Googler, 2011/08/09 20:33:37]

NOTREACHED() means you'll never get to the Close() and false return.

Also, is it possible/likely that Chromium will be linked with versions of SQLite
which do not support this pragma?

[Paweł Hajdan Jr., 2011/08/09 23:05:00]

I used NOTREACHED() because code above uses it. However, NOTREACHED() will not
fire in Release mode, and in this case I believe it's really important to ensure
we succeed with running this pragma.
Possible, but not likely. If some distro breaks it it's their fault. And distros
do their testing too. It's only important to make it fail loudly, i.e. fail the
connection instead of just logging somewhere where possibly nobody is looking.

[Scott Hess - ex-Googler, 2011/08/09 23:13:44]

Doh!  You're right, for some reason I was thinking it did a CHECK() not a
DCHECK().
OK.  As long as the case was realized.

+    Close();
+    return false;
+  }
+
   return true;
 }