Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: ppapi/proxy/ppb_file_system_proxy.cc

Issue 7551032: Add a template to handle properly issuing completion callbacks. This fixes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_file_system_proxy.cc
===================================================================
--- ppapi/proxy/ppb_file_system_proxy.cc (revision 94913)
+++ ppapi/proxy/ppb_file_system_proxy.cc (working copy)
@@ -174,16 +174,11 @@
void PPB_FileSystem_Proxy::OnMsgOpen(const HostResource& host_resource,
int64_t expected_size) {
- EnterHostFromHostResource<PPB_FileSystem_API> enter(host_resource);
- if (enter.failed())
- return;
-
- CompletionCallback callback = callback_factory_.NewOptionalCallback(
+ EnterHostFromHostResourceForceCallback<PPB_FileSystem_API> enter(
+ host_resource, callback_factory_,
&PPB_FileSystem_Proxy::OpenCompleteInHost, host_resource);
- int32_t result = enter.object()->Open(expected_size,
- callback.pp_completion_callback());
- if (result != PP_OK_COMPLETIONPENDING)
- callback.Run(result);
+ if (enter.succeeded())
+ enter.SetResult(enter.object()->Open(expected_size, enter.callback()));
}
// Called in the plugin to handle the open callback.

Powered by Google App Engine
This is Rietveld 408576698