Adding service_name to GaiaOAuthFetcher

Adding service_name to GaiaOAuthFetcher

BUG=91434
TEST=unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95333

[Rick Campbell, 2011-08-02 22:50:36]

Please take a look.

[zel, 2011-08-02 22:59:33]

you are missing changes in chrome/browser/chromeos/login_utils.cc, search for
class PolicyOAuthFetcher, method Start()

[Mattias Nissler (ping if slow), 2011-08-03 08:36:26]

http://codereview.chromium.org/7551026/diff/12001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7551026/diff/12001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_utils.cc:204: GaiaConstants::kSyncService,
If I understand correctly, this is the GAIA service name. For policy, this is
actually "mobilesync", i.e. GaiaConstants::kDeviceManagementService.

[Rick Campbell, 2011-08-03 08:46:58]

Please take another look

[Mattias Nissler (ping if slow), 2011-08-03 08:51:58]

On 2011/08/03 08:46:58, Rick Campbell wrote:
> Please take another look

Crossing messages? My comment regarding the scope for policy still applies.

[Rick Campbell, 2011-08-03 13:07:06]

Please take another look.

Yes, sorry, that was crossing messages.  I've now made the change you suggested
and one other instance of the same issue.

All of these will change again with my next patch, which depends on this one
landing.

At that point, the (currently unused) service name will be used as a key in a
service_name-to-token table within TokenService.  Services capable of supporting
either/both of ClientLogin and OAuth will need to use distinct keys for the two
authentication mechanisms.

In the case of Sync, ClientLogin uses kSyncService ("chromiumsync").  My next
patch will introduce kSyncServiceOAuth ("sync") and use it to replace all
instances of kSyncService that are in OAuth contexts.  I will do similarly for
kDeviceManagementService.  What literal value (different from "mobilesync")
would you like me to use for kDeviceManagementServiceOAuth?

http://codereview.chromium.org/7551026/diff/12001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7551026/diff/12001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_utils.cc:204: GaiaConstants::kSyncService,
On 2011/08/03 08:36:26, Mattias Nissler wrote:
> If I understand correctly, this is the GAIA service name. For policy, this is
> actually "mobilesync", i.e. GaiaConstants::kDeviceManagementService.

Done.

http://codereview.chromium.org/7551026/diff/12001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_utils.cc:215:
std::string(GaiaConstants::kSyncService),
This has the same issue that Mattias identified above.

[zel, 2011-08-03 18:04:21]

LGTM

[Roger Tawa OOO till Jul 10th, 2011-08-03 19:01:31]

lgtm

[commit-bot: I haz the power, 2011-08-03 21:58:54]

Change committed as 95333