Add support for WebURLRequest::TargetIsXHR (part I)

Add support for WebURLRequest::TargetIsXHR (part I)

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95343

[jochen (gone - plz use gerrit), 2011-08-02 18:17:04]

please review

webkit side is here: https://bugs.webkit.org/show_bug.cgi?id=65544

[darin (slow to review), 2011-08-02 18:26:56]

Is this about fixing a particular bug?  From what I can tell, you are trying to
lower the priority of XHR requests.  What motivates you to want to do that?

[jochen (gone - plz use gerrit), 2011-08-02 18:44:15]

On 2011/08/02 18:26:56, darin wrote:
> Is this about fixing a particular bug?  From what I can tell, you are trying
to
> lower the priority of XHR requests.  What motivates you to want to do that?

No, this doesn't change the priority. Right now, XHRs are being sent as
SUB_RESOURCE.

I want to be able to tell XHRs apart from other uncategorized requests
(SUB_RESOURCE is basically "no category") for the webRequest extension API

[darin (slow to review), 2011-08-02 19:29:18]

On Tue, Aug 2, 2011 at 11:44 AM, <jochen@chromium.org> wrote:

> On 2011/08/02 18:26:56, darin wrote:
>
>> Is this about fixing a particular bug?  From what I can tell, you are
>> trying
>>
> to
>
>> lower the priority of XHR requests.  What motivates you to want to do
>> that?
>>
>
> No, this doesn't change the priority. Right now, XHRs are being sent as
> SUB_RESOURCE.
>
> I want to be able to tell XHRs apart from other uncategorized requests
> (SUB_RESOURCE is basically "no category") for the webRequest extension API
>
>
>
Ah


>
http://codereview.chromium.**org/7551019/<http://codereview.chromium.org/7551...
>

[darin (slow to review), 2011-08-02 19:32:08]

LGTM

http://codereview.chromium.org/7551019/diff/2002/webkit/glue/weburlloader_imp...
File webkit/glue/weburlloader_impl.cc (right):

http://codereview.chromium.org/7551019/diff/2002/webkit/glue/weburlloader_imp...
webkit/glue/weburlloader_impl.cc:144: #if defined(OS_WIN)
the way we typically accomplish this is with an #if
defined(WEBKIT_HAS_TARGET_TYPE_XHR) or some such macro.  then you would just
write:

 #if defined(WEBKIT_HAS_TARGET_TYPE_XHR)
     case WebURLRequest::TargetIsXHR:
       return ResourceType::XHR;
 #endif

And, in the WebKit patch, WebURLRequest.h would define that macro.

[commit-bot: I haz the power, 2011-08-03 22:48:00]

Change committed as 95343