src/ia32/stub-cache-ia32.cc - Issue 7551009: Ensure that GenerateStoreFastDoubleElement returns stored value on all paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 7551009: Ensure that GenerateStoreFastDoubleElement returns stored value on all paths. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

===================================================================

--- src/ia32/stub-cache-ia32.cc (revision 8772)

+++ src/ia32/stub-cache-ia32.cc (working copy)

@@ -3981,10 +3981,12 @@

__ bind(&smi_value);

// Value is a smi. convert to a double and store.

- __ SmiUntag(eax);

- __ push(eax);

+ // Preserve original value.

+ __ mov(edx, eax);

+ __ SmiUntag(edx);

+ __ push(edx);

__ fild_s(Operand(esp, 0));

- __ pop(eax);

+ __ pop(edx);

__ fstp_d(FieldOperand(edi, ecx, times_4, FixedDoubleArray::kHeaderSize));

__ ret(0);

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »