Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 7551009: Ensure that GenerateStoreFastDoubleElement returns stored value on all paths. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4381 matching lines...) Expand 10 before | Expand all | Expand 10 after
4392 __ add(scratch, scratch, 4392 __ add(scratch, scratch,
4393 Operand(key_reg, LSL, kDoubleSizeLog2 - kSmiTagSize)); 4393 Operand(key_reg, LSL, kDoubleSizeLog2 - kSmiTagSize));
4394 // scratch is now effective address of the double element 4394 // scratch is now effective address of the double element
4395 4395
4396 FloatingPointHelper::Destination destination; 4396 FloatingPointHelper::Destination destination;
4397 if (CpuFeatures::IsSupported(VFP3)) { 4397 if (CpuFeatures::IsSupported(VFP3)) {
4398 destination = FloatingPointHelper::kVFPRegisters; 4398 destination = FloatingPointHelper::kVFPRegisters;
4399 } else { 4399 } else {
4400 destination = FloatingPointHelper::kCoreRegisters; 4400 destination = FloatingPointHelper::kCoreRegisters;
4401 } 4401 }
4402 __ SmiUntag(value_reg, value_reg); 4402
4403 Register untagged_value = receiver_reg;
4404 __ SmiUntag(untagged_value, value_reg);
4403 FloatingPointHelper::ConvertIntToDouble( 4405 FloatingPointHelper::ConvertIntToDouble(
4404 masm, value_reg, destination, 4406 masm,
4405 d0, mantissa_reg, exponent_reg, // These are: double_dst, dst1, dst2. 4407 untagged_value,
4406 scratch4, s2); // These are: scratch2, single_scratch. 4408 destination,
4409 d0,
4410 mantissa_reg,
4411 exponent_reg,
4412 scratch4,
4413 s2);
4407 if (destination == FloatingPointHelper::kVFPRegisters) { 4414 if (destination == FloatingPointHelper::kVFPRegisters) {
4408 CpuFeatures::Scope scope(VFP3); 4415 CpuFeatures::Scope scope(VFP3);
4409 __ vstr(d0, scratch, 0); 4416 __ vstr(d0, scratch, 0);
4410 } else { 4417 } else {
4411 __ str(mantissa_reg, MemOperand(scratch, 0)); 4418 __ str(mantissa_reg, MemOperand(scratch, 0));
4412 __ str(exponent_reg, MemOperand(scratch, Register::kSizeInBytes)); 4419 __ str(exponent_reg, MemOperand(scratch, Register::kSizeInBytes));
4413 } 4420 }
4414 __ Ret(); 4421 __ Ret();
4415 4422
4416 // Handle store cache miss, replacing the ic with the generic stub. 4423 // Handle store cache miss, replacing the ic with the generic stub.
4417 __ bind(&miss_force_generic); 4424 __ bind(&miss_force_generic);
4418 Handle<Code> ic = 4425 Handle<Code> ic =
4419 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric(); 4426 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric();
4420 __ Jump(ic, RelocInfo::CODE_TARGET); 4427 __ Jump(ic, RelocInfo::CODE_TARGET);
4421 } 4428 }
4422 4429
4423 4430
4424 #undef __ 4431 #undef __
4425 4432
4426 } } // namespace v8::internal 4433 } } // namespace v8::internal
4427 4434
4428 #endif // V8_TARGET_ARCH_ARM 4435 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698