Issue 7551004: Properly handle FastDoubleArrays in Runtime_MoveArrayContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7551004: Properly handle FastDoubleArrays in Runtime_MoveArrayContents (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Properly handle FastDoubleArrays in Runtime_MoveArrayContents BUG=91013 TEST=regress91013.js Committed: http://code.google.com/p/v8/source/detail?r=8773

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1

Patch Set 3 : fix nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -2 lines)			Patch
M	src/objects-inl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-91010.js	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 4 months ago (2011-08-02 09:27:18 UTC) #1

LGTM

http://codereview.chromium.org/7551004/diff/8/test/mjsunit/regress/regress-91...
File test/mjsunit/regress/regress-91010.js (right):

http://codereview.chromium.org/7551004/diff/8/test/mjsunit/regress/regress-91...
test/mjsunit/regress/regress-91010.js:1: // Copyright 2010 the V8 project
authors. All rights reserved.
nit: 2011

Expand Messages | Collapse Messages