Issue 7550059: Move sqlite_utils.* to sync/util/ directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7550059: Move sqlite_utils.* to sync/util/ directory. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move sqlite_utils.* to sync/util/ directory. BUG=77634 TEST=None R=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95927

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -923 lines)			Patch
M	chrome/browser/sync/syncable/directory_backing_store.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/sync/util/sqlite_utils.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/sync/util/sqlite_utils.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/util/user_settings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/util/user_settings_posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/util/user_settings_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/common/sqlite_utils.h	View	1 chunk	+0 lines, -400 lines	0 comments	Download
D	chrome/common/sqlite_utils.cc	View	1 chunk	+0 lines, -510 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

I don't think this is the best thing to do. But at least it helps ...

9 years, 4 months ago (2011-08-06 22:54:15 UTC) #1

akalin

9 years, 4 months ago (2011-08-09 00:59:03 UTC) #2

On 2011/08/06 22:54:15, tfarina wrote:
> I don't think this is the best thing to do.
> 
> But at least it helps to isolate this deprecated API where it's solo used now.
> 
> If you think we shouldn't move it, just tell me and I close this patch (I
don't
> feel very strong about this).
> 
> I was planning to clean up the file further more after moving it though.
> 
> Thanks!

LGTM

Expand Messages | Collapse Messages