Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 7550055: Remove idb transaction callbacks onTimeout stuff that was removed from the spec. (Closed)

Created:
9 years, 4 months ago by dgrogan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Remove idb transaction callbacks onTimeout stuff that was removed from the spec. Step 1 was https://bugs.webkit.org/show_bug.cgi?id=53521 This is step 2. 3 is to remove WebIDBTransactionCallbacks::onTimeout from the webkit api. BUG= TEST=llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96044

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove message definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M content/browser/in_process_webkit/indexed_db_transaction_callbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/indexed_db_messages.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/indexed_db_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/indexed_db_dispatcher.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrogan
Hans, could you review this?
9 years, 4 months ago (2011-08-06 01:21:11 UTC) #1
hans
On 2011/08/06 01:21:11, dgrogan wrote: > Hans, could you review this? LGTM, thanks for picking ...
9 years, 4 months ago (2011-08-08 15:31:24 UTC) #2
michaeln
http://codereview.chromium.org/7550055/diff/1/content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc File content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc (left): http://codereview.chromium.org/7550055/diff/1/content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc#oldcode32 content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc:32: new IndexedDBMsg_TransactionCallbacksTimeout(transaction_id_)); drive by: this message type definition can ...
9 years, 4 months ago (2011-08-08 18:05:31 UTC) #3
dgrogan
http://codereview.chromium.org/7550055/diff/1/content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc File content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc (left): http://codereview.chromium.org/7550055/diff/1/content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc#oldcode32 content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc:32: new IndexedDBMsg_TransactionCallbacksTimeout(transaction_id_)); On 2011/08/08 18:05:31, michaeln wrote: > drive ...
9 years, 4 months ago (2011-08-08 18:45:25 UTC) #4
commit-bot: I haz the power
Presubmit check for 7550055-4002 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-09 06:35:23 UTC) #5
dgrogan
jam, Could you review this for OWNERS approval? Thanks.
9 years, 4 months ago (2011-08-09 06:40:14 UTC) #6
jam
lgtm
9 years, 4 months ago (2011-08-09 16:21:42 UTC) #7
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 19:57:12 UTC) #8
Change committed as 96044

Powered by Google App Engine
This is Rietveld 408576698