Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 7550050: Convert LocationBar::GetInputString from wstring to string16. (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert LocationBar::GetInputString from wstring to string16. Also add OVERRIDE to the GTK+ and OSX implementations. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95839

Patch Set 1 #

Total comments: 1

Patch Set 2 : gurl string16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M chrome/browser/extensions/extension_omnibox_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 2 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_location_bar.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/base/test_location_bar.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
9 years, 4 months ago (2011-08-08 16:05:08 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/7550050/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7550050/diff/1/chrome/browser/ui/browser.cc#newcode1439 chrome/browser/ui/browser.cc:1439: GURL url(UTF16ToUTF8(location_bar->GetInputString())); It appears you can construct a ...
9 years, 4 months ago (2011-08-08 16:34:05 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-08 18:10:15 UTC) #3
Change committed as 95839

Powered by Google App Engine
This is Rietveld 408576698