Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 7550048: CrOS OOBE: Load gaia login frame only after dialogArguments have been initialized. (Closed)

Created:
9 years, 4 months ago by Mattias Nissler (ping if slow)
Modified:
9 years, 4 months ago
Reviewers:
whywhat, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

CrOS OOBE: Load gaia login frame only after dialogArguments have been initialized. If the gaia login frame is loaded right away when the main OOBE UI loads, there's no chance for the enrollment handler to set up chrome.dialogArguments, which gaia_login.js however requires to initialize correctly. So, defer loading of the gaia login frame to the point the enterprise enrollment screen actually gets shown. BUG=chromium-os:18736 TEST=Enrollment triggered through the accelerator finally works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_enrollment.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Actually, here is another CL that I forgot to upload earlier.
9 years, 4 months ago (2011-08-05 22:29:07 UTC) #1
James Hawkins
LGTM with nit. http://codereview.chromium.org/7550048/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js File chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js (right): http://codereview.chromium.org/7550048/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js#newcode41 chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js:41: * @param data {object} Screen init ...
9 years, 4 months ago (2011-08-05 22:36:19 UTC) #2
whywhat
LGTM
9 years, 4 months ago (2011-08-08 08:11:14 UTC) #3
Mattias Nissler (ping if slow)
9 years, 4 months ago (2011-08-08 11:29:08 UTC) #4
http://codereview.chromium.org/7550048/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js (right):

http://codereview.chromium.org/7550048/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe_screen_enrollment.js:41: * @param
data {object} Screen init payload.
On 2011/08/05 22:36:19, James Hawkins wrote:
> @param {object} data

Done.

Powered by Google App Engine
This is Rietveld 408576698