CrOS OOBE: Grab accelerators in native code instead of JS.

chrome/browser/chromeos/login/webui_login_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/webui_login_view.h"
 
 #include "chrome/browser/chromeos/accessibility_util.h"
 #include "chrome/browser/chromeos/login/proxy_settings_dialog.h"
 #include "chrome/browser/chromeos/login/webui_login_display.h"
 #include "chrome/browser/chromeos/status/clock_menu_button.h"
 #include "chrome/browser/chromeos/status/input_method_menu_button.h"
 #include "chrome/browser/chromeos/status/network_menu_button.h"
 #include "chrome/browser/chromeos/status/status_area_view.h"
 #include "chrome/browser/chromeos/wm_ipc.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/views/dom_view.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/size.h"
 #include "views/widget/widget.h"
 
 namespace {
 
 const char kViewClassName[] = "browser/chromeos/login/WebUILoginView";
 
+// These strings must be kept in sync with handleAccelerator() in oobe.js.
+const char kAccelNameAccessibility[] = "accessibility";
+const char kAccelNameEnrollment[] = "enrollment";
+
 }  // namespace
 
 namespace chromeos {
 
 // static
 const int WebUILoginView::kStatusAreaCornerPadding = 5;
 
 // WebUILoginView public: ------------------------------------------------------
 
 WebUILoginView::WebUILoginView()
     : status_area_(NULL),
       profile_(NULL),
       webui_login_(NULL),
-      status_window_(NULL),
-      accel_toggle_accessibility_(
-          views::Accelerator(ui::VKEY_Z, false, true, true)) {
-  // Accelerator events will be sent to this window until the WebUI dialog gains
-  // focus via keyboard or mouse input, so we have to watch for the
-  // accessibility hotkey here as well.
-  AddAccelerator(accel_toggle_accessibility_);
+      status_window_(NULL) {
+  accel_map_[views::Accelerator(ui::VKEY_Z, false, true, true)] =
+      kAccelNameAccessibility;
+  accel_map_[views::Accelerator(ui::VKEY_E, false, true, true)] =
+      kAccelNameEnrollment;
+
+  for (AccelMap::iterator i(accel_map_.begin()); i != accel_map_.end(); ++i)
+    AddAccelerator(i->first);
 }
 
 WebUILoginView::~WebUILoginView() {
   if (status_window_)
     status_window_->Close();
   status_window_ = NULL;
 }
 
 void WebUILoginView::Init() {
   profile_ = ProfileManager::GetDefaultProfile();
 
   webui_login_ = new DOMView();
   AddChildView(webui_login_);
   webui_login_->Init(profile_, NULL);
   webui_login_->SetVisible(true);
   webui_login_->tab_contents()->set_delegate(this);
 }
 
 std::string WebUILoginView::GetClassName() const {
   return kViewClassName;
 }
 
 bool WebUILoginView::AcceleratorPressed(
     const views::Accelerator& accelerator) {
-  if (accelerator == accel_toggle_accessibility_) {
-    accessibility::ToggleAccessibility();
-  } else {
+  AccelMap::const_iterator entry = accel_map_.find(accelerator);
+  if (entry == accel_map_.end())
     return false;
+
+  WebUI* web_ui = webui_login_ ? webui_login_->tab_contents()->web_ui() : NULL;
+  if (web_ui) {

[whywhat, 2011/08/08 08:09:08]

Maybe change to:
if (webui_login_) {
  WebUI* web_ui = webui_login_->tab_contents()->web_ui();
  ...
}
?

[Mattias Nissler (ping if slow), 2011/08/08 11:11:47]

I put a webui_login_ NULL check with early return in. The web_ui NULL check is
still present, so we don't crash when the web_ui is not yet present.

+    base::StringValue accel_name(entry->second);
+    web_ui->CallJavascriptFunction("cr.ui.Oobe.handleAccelerator",
+                                   accel_name);
   }
+
   return true;
 }
 
 gfx::NativeWindow WebUILoginView::GetNativeWindow() const {
   return GetWidget()->GetNativeWindow();
 }
 
 void WebUILoginView::OnWindowCreated() {
   InitStatusArea();
 }
@@ skipping 119 matching lines @@
 
 bool WebUILoginView::HandleContextMenu(const ContextMenuParams& params) {
   // Do not show the context menu.
 #ifndef NDEBUG
   return false;
 #else
   return true;
 #endif
 }
 
+void WebUILoginView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {
+  unhandled_keyboard_event_handler_.HandleKeyboardEvent(event,
+                                                        GetFocusManager());
+}
+
 }  // namespace chromeos