Revert 95621 - Keeping the current directory in URL.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 13 matching lines @@
  *     the root filesystem for the new FileManager.
  * @param {Object} params A map of parameter names to values controlling the
  *     appearance of the FileManager.  Names are:
  *     - type: A value from FileManager.DialogType defining what kind of
  *       dialog to present.  Defaults to FULL_PAGE.
  *     - title: The title for the dialog.  Defaults to a localized string based
  *       on the dialog type.
  *     - defaultPath: The default path for the dialog.  The default path should
  *       end with a trailing slash if it represents a directory.
  */
-function FileManager(dialogDom, filesystem, rootEntries) {
+function FileManager(dialogDom, filesystem, rootEntries, params) {
   console.log('Init FileManager: ' + dialogDom);
 
   this.dialogDom_ = dialogDom;
   this.rootEntries_ = rootEntries;
   this.filesystem_ = filesystem;
-  this.params_ = location.search ?
-                 JSON.parse(decodeURIComponent(location.search.substr(1))) :
-                 {};
+  this.params_ = params || {};
 
   this.listType_ = null;
 
   this.metadataCache_ = {};
 
   this.selection = null;
 
   this.clipboard_ = null;  // Current clipboard, or null if empty.
 
   this.butterTimer_ = null;
@@ skipping 74 matching lines @@
   chrome.fileBrowserPrivate.getMountPoints(function(mountPoints) {
       self.mountPoints_ = mountPoints;
   });
 
   chrome.fileBrowserHandler.onExecute.addListener(
     this.onFileTaskExecute_.bind(this));
 
   this.initCommands_();
   this.initDom_();
   this.initDialogType_();
-  this.setupCurrentDirectory_();
+  this.initDefaultDirectory_(this.params_.defaultPath);
 
   this.summarizeSelection_();
   this.updatePreview_();
 
   chrome.fileBrowserPrivate.onDiskChanged.addListener(
       this.onDiskChanged_.bind(this));
 
   this.refocus();
 
   // Pass all URLs to the metadata reader until we have a correct filter.
@@ skipping 643 matching lines @@
           this.pasteButton_.disabled = !event.canExecute;
         break;
 
       case 'rename':
         event.canExecute =
           (// Initialized to the point where we have a current directory
            this.currentDirEntry_ &&
            // Rename not in progress.
            !this.renameInput_.currentEntry &&
            // Only one file selected.
-           this.selection &&
            this.selection.totalCount == 1 &&
            !isSystemDirEntry(this.currentDirEntry_));
          break;
 
       case 'delete':
         event.canExecute =
           (// Initialized to the point where we have a current directory
            this.currentDirEntry_ &&
            // Rename not in progress.
            !this.renameInput_.currentEntry &&
@@ skipping 182 matching lines @@
         this.initiateRename_(label);
         return;
 
       case 'delete':
         this.deleteEntries(this.selection.entries);
         return;
     }
   };
 
   /**
-   * Respond to the back and forward buttons.
+   * Respond to the back button.
    */
   FileManager.prototype.onPopState_ = function(event) {
-    // TODO(serya): We should restore selected items here.
-    this.setupCurrentDirectory_();
+    this.changeDirectory(event.state, CD_NO_HISTORY);
   };
 
   /**
    * Resize details and thumb views to fit the new window size.
    */
   FileManager.prototype.onResize_ = function() {
     this.table_.style.height = this.grid_.style.height =
       this.grid_.parentNode.clientHeight + 'px';
     this.table_.style.width = this.grid_.style.width =
       this.grid_.parentNode.clientWidth + 'px';
@@ skipping 12 matching lines @@
       this.currentList_.redraw();
     }
   };
 
   FileManager.prototype.resolvePath = function(
       path, resultCallback, errorCallback) {
     return util.resolvePath(this.filesystem_.root, path, resultCallback,
                             errorCallback);
   };
 
-  /**
-   * Restores current directory and may be a selected item after page load (or
-   * reload) or popping a state (after click on back/forward). If location.hash
-   * is present it means that the user has navigated somewhere and that place
-   * will be restored. defaultPath primarily is used with save/open dialogs.
-   * Default path may also contain a file name. Freshly opened file manager
-   * window has neither.
-   */
-  FileManager.prototype.setupCurrentDirectory_ = function() {
-    if (location.hash) {
-      // Location hash has the highest priority.
-      var path = decodeURI(location.hash.substr(1));
-      this.changeDirectory(path, CD_NO_HISTORY);
-      return;
-    } else if (this.params_.defaultPath) {
-      this.setupPath_(this.params_.defaultPath);
-    } else {
-      this.setupDefaultPath_();
-    }
-  };
+  FileManager.prototype.initDefaultDirectory_ = function(path) {
+    if (!path) {
+      // No preset given, find a good place to start.
+      // Check for removable devices, if there are none, go to Downloads.
+      for (var i = 0; i != this.rootEntries_.length; i++) {
+        var rootEntry = this.rootEntries_[i];
+        if (rootEntry.fullPath == REMOVABLE_DIRECTORY) {
+          var foundRemovable = false;
+          var self = this;
+          util.forEachDirEntry(rootEntry, function(result) {
+            if (result) {
+              foundRemovable = true;
+            } else {  // Done enumerating, and we know the answer.
+              self.initDefaultDirectory_(
+                  foundRemovable ? '/' : DOWNLOADS_DIRECTORY);
+            }
+          });
+          return;
+        }
+      }
 
-  FileManager.prototype.setupDefaultPath_ = function() {
-    // No preset given, find a good place to start.
-    // Check for removable devices, if there are none, go to Downloads.
-    var removableDirectoryEntry = this.rootEntries_.filter(function(rootEntry) {
-      return rootEntry.fullPath == REMOVABLE_DIRECTORY;
-    })[0];
-    if (!removableDirectoryEntry) {
-      this.changeDirectory(DOWNLOADS_DIRECTORY, CD_NO_HISTORY);
-      return;
+      // Removable root directory is missing altogether.
+      path = DOWNLOADS_DIRECTORY;
     }
 
-    var foundRemovable = false;
-    util.forEachDirEntry(removableDirectoryEntry, function(result) {
-      if (result) {
-        foundRemovable = true;
-      } else {  // Done enumerating, and we know the answer.
-        this.changeDirectory(foundRemovable ? '/' : DOWNLOADS_DIRECTORY,
-                             CD_NO_HISTORY);
-      }
-    }.bind(this));
-  };
-
-  FileManager.prototype.setupPath_ = function(path) {
     // Split the dirname from the basename.
     var ary = path.match(/^(.*?)(?:\/([^\/]+))?$/);
     if (!ary) {
       console.warn('Unable to split default path: ' + path);
       self.changeDirectory('/', CD_NO_HISTORY);
       return;
     }
 
     var baseName = ary[1];
     var leafName = ary[2];
@@ skipping 907 matching lines @@
    *
    * @param {string} path The absolute path to the new directory.
    * @param {bool} opt_saveHistory Save this in the history stack (defaults
    *     to true).
    * @param {string} opt_selectedEntry The name of the file to select after
    *     changing directories.
    */
   FileManager.prototype.changeDirectoryEntry = function(dirEntry,
                                                         opt_saveHistory,
                                                         opt_selectedEntry) {
-    if (typeof opt_saveHistory == 'undefined') {
-      opt_saveHistory = true;
-    } else {
-      opt_saveHistory = !!opt_saveHistory;
-    }
-
-    var location = '#' + encodeURI(dirEntry.fullPath);
-    if (opt_saveHistory) {
-      history.pushState(undefined, dirEntry.fullPath, location);
-    } else if (window.location.hash != location) {
-      // If the user typed URL manually that is not canonical it would be fixed
-      // here. However it seems history.replaceState doesn't work properly
-      // with rewritable URLs (while does with history.pushState). It changes
-      // window.location but doesn't change content of the ombibox.
-      history.replaceState(undefined, dirEntry.fullPath, location);
-    }
-
     if (this.currentDirEntry_ &&
         this.currentDirEntry_.fullPath == dirEntry.fullPath) {
       // Directory didn't actually change.
       if (opt_selectedEntry)
         this.selectEntry(opt_selectedEntry);
       return;
     }
 
+    if (typeof opt_saveHistory == 'undefined') {
+      opt_saveHistory = true;
+    } else {
+      opt_saveHistory = !!opt_saveHistory;
+    }
+
     var e = new cr.Event('directory-changed');
     e.previousDirEntry = this.currentDirEntry_;
     e.newDirEntry = dirEntry;
     e.saveHistory = opt_saveHistory;
     e.selectedEntry = opt_selectedEntry;
     this.currentDirEntry_ = dirEntry;
     this.dispatchEvent(e);
   }
 
   /**
    * Change the current directory to the directory represented by a string
    * path.
    *
    * Dispatches the 'directory-changed' event when the directory is successfully
    * changed.
    *
    * @param {string} path The absolute path to the new directory.
    * @param {bool} opt_saveHistory Save this in the history stack (defaults
    *     to true).
    * @param {string} opt_selectedEntry The name of the file to select after
    *     changing directories.
    */
   FileManager.prototype.changeDirectory = function(path,
                                                    opt_saveHistory,
                                                    opt_selectedEntry) {
     if (path == '/')
-      return this.changeDirectoryEntry(this.filesystem_.root,
-                                       opt_saveHistory,
-                                       opt_selectedEntry);
+      return this.changeDirectoryEntry(this.filesystem_.root);
 
     var self = this;
 
     this.filesystem_.root.getDirectory(
         path, {create: false},
         function(dirEntry) {
           self.changeDirectoryEntry(
               dirEntry, opt_saveHistory, opt_selectedEntry);
         },
         function(err) {
           console.error('Error changing directory to: ' + path + ', ' + err);
-          if (self.currentDirEntry_) {
-            var location = '#' + encodeURI(self.currentDirEntry_.fullPath);
-            history.replaceState(undefined,
-                                 self.currentDirEntry_.fullPath,
-                                 location);
-          } else {
+          if (!self.currentDirEntry_) {
             // If we've never successfully changed to a directory, force them
             // to the root.
             self.changeDirectory('/', false);
           }
         });
   };
 
   FileManager.prototype.deleteEntries = function(entries, force) {
     if (!force) {
       var self = this;
@@ skipping 271 matching lines @@
       this.onOk_();
 
   };
 
   /**
    * Update the UI when the current directory changes.
    *
    * @param {cr.Event} event The directory-changed event.
    */
   FileManager.prototype.onDirectoryChanged_ = function(event) {
+    if (event.saveHistory) {
+      history.pushState(this.currentDirEntry_.fullPath,
+                        this.currentDirEntry_.fullPath,
+                        location.href);
+    }
+
     this.updateCommands_();
     this.updateOkButton_();
 
     // New folder should never be enabled in the root or media/ directories.
     this.newFolderButton_.disabled = isSystemDirEntry(this.currentDirEntry_);
 
     this.document_.title = this.currentDirEntry_.fullPath;
 
     var self = this;
     this.rescanDirectory_(function() {
@@ skipping 448 matching lines @@
       case 69:  // Ctrl-E => Rename.
         this.updateCommands_();
         if (!this.commands_['rename'].disabled) {
           event.preventDefault();
           this.commands_['rename'].execute();
         }
         break;
 
       case 46:  // Delete.
         if (this.dialogType_ == FileManager.DialogType.FULL_PAGE &&
-            this.selection && this.selection.totalCount > 0 &&
+            this.selection.totalCount > 0 &&
             !isSystemDirEntry(this.currentDirEntry_)) {
           event.preventDefault();
           this.deleteEntries(this.selection.entries);
         }
         break;
     }
   };
 
   /**
    * KeyPress event handler for the div.list-container element.
@@ skipping 177 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();