Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 7550030: Make GYP build usable for day-to-day work (second attempt) (Closed)

Created:
9 years, 4 months ago by Jakob Kummerow
Modified:
9 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make GYP build usable for day-to-day work (second attempt) - Introduce a global Makefile that triggers GYP-based building - Some fixes to .gyp[i] files to make everything work - tools/test-wrapper-gypbuild.py as a temporary solution for easy testing Original review URL: http://codereview.chromium.org/7383006/ Committed: http://code.google.com/p/v8/source/detail?r=8840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+551 lines, -93 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A Makefile View 1 chunk +113 lines, -0 lines 0 comments Download
M build/all.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M build/armu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +22 lines, -4 lines 0 comments Download
M build/v8-features.gypi View 1 chunk +13 lines, -0 lines 0 comments Download
A + preparser/preparser.gyp View 1 chunk +12 lines, -7 lines 0 comments Download
M samples/samples.gyp View 2 chunks +10 lines, -9 lines 0 comments Download
M src/d8.gyp View 3 chunks +17 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/testcfg.py View 2 chunks +11 lines, -2 lines 0 comments Download
M test/preparser/testcfg.py View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 22 chunks +106 lines, -64 lines 0 comments Download
M tools/test.py View 3 chunks +9 lines, -0 lines 0 comments Download
A tools/test-wrapper-gypbuild.py View 1 chunk +223 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL. Changes since last review (see link): • rebased onto current bleeding_edge • added 'weakmap.js' ...
9 years, 4 months ago (2011-08-05 09:09:38 UTC) #1
Yang
9 years, 4 months ago (2011-08-05 09:39:32 UTC) #2
LGTM.

On 2011/08/05 09:09:38, jkummerow wrote:
> PTAL.
> 
> Changes since last review (see link):
> • rebased onto current bleeding_edge
> • added 'weakmap.js' to v8.gyp
> • added targets à la "ia32.check" to Makefile

Powered by Google App Engine
This is Rietveld 408576698