base: Remove using declaration of BinaryValue as it's no longer necessary.

base: Remove using declaration of BinaryValue as it's no longer necessary.

BUG=None
TEST=None

R=evan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95638

[Evan Martin, 2011-08-05 07:11:11]

There's a thread about this on chromium-dev right now.  Did we reach a
conclusion?

On Thu, Aug 4, 2011 at 9:42 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> base: Remove using declaration of BinaryValue as it's no longer necessary.
>
> BUG=None
> TEST=None
>
> R=evan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7550026/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/values.h
>  M chrome/browser/extensions/extension_app_api.cc
>  M chrome/browser/extensions/extension_browser_actions_api.cc
>  M chrome/browser/extensions/extension_page_actions_module.cc
>  M chrome/browser/extensions/extension_sidebar_api.cc
>  M chrome/browser/policy/user_policy_cache.cc
>  M chrome/renderer/extensions/extension_process_bindings.cc
>  M ipc/ipc_message_utils.cc
>
>
> Index: base/values.h
> diff --git a/base/values.h b/base/values.h
> index
>
55e7be08aaffa02af4c6d0e0883c32ef9f4af157..54c33e6f66909c20435c0b7b74a2d3b6a257816d
> 100644
> --- a/base/values.h
> +++ b/base/values.h
> @@ -30,7 +30,6 @@
>  #include "base/base_api.h"
>  #include "base/basictypes.h"
>  #include "base/string16.h"
> -#include "build/build_config.h"
>
>  // This file declares "using base::Value", etc. at the bottom, so that
>  // current code can use these classes without the base namespace. In
> @@ -49,9 +48,9 @@ class Value;
>  typedef std::vector<Value*> ValueVector;
>  typedef std::map<std::string, Value*> ValueMap;
>
> -// The Value class is the base class for Values.  A Value can be
> -// instantiated via the Create*Value() factory methods, or by directly
> -// creating instances of the subclasses.
> +// The Value class is the base class for Values. A Value can be
> instantiated
> +// via the Create*Value() factory methods, or by directly creating
> instances of
> +// the subclasses.
>  class BASE_API Value {
>  public:
>   enum ValueType {
> @@ -465,7 +464,6 @@ class BASE_API ValueSerializer {
>  }  // namespace base
>
>  // http://crbug.com/88666
> -using base::BinaryValue;
>  using base::DictionaryValue;
>  using base::FundamentalValue;
>  using base::ListValue;
> Index: chrome/browser/extensions/extension_app_api.cc
> diff --git a/chrome/browser/extensions/extension_app_api.cc
> b/chrome/browser/extensions/extension_app_api.cc
> index
>
91899e91e9faa63dad8c2bb83f1438a1d7f91104..cc545fad3421fd1ed22f346eb3d0ffb73ca699e2
> 100644
> --- a/chrome/browser/extensions/extension_app_api.cc
> +++ b/chrome/browser/extensions/extension_app_api.cc
> @@ -123,7 +123,7 @@ bool AppNotifyFunction::RunImpl() {
>   }
>
>   if (details->HasKey(kIconDataKey)) {
> -    BinaryValue* binary = NULL;
> +    base::BinaryValue* binary = NULL;
>     EXTENSION_FUNCTION_VALIDATE(details->GetBinary(kIconDataKey, &binary));
>     IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());
>     void* iter = NULL;
> Index: chrome/browser/extensions/extension_browser_actions_api.cc
> diff --git a/chrome/browser/extensions/extension_browser_actions_api.cc
> b/chrome/browser/extensions/extension_browser_actions_api.cc
> index
>
750d12195c286537092c2d312346a4f7ff551e1f..562c479dc577aa031705722f619b93f287a3d3a6
> 100644
> --- a/chrome/browser/extensions/extension_browser_actions_api.cc
> +++ b/chrome/browser/extensions/extension_browser_actions_api.cc
> @@ -46,7 +46,7 @@ bool BrowserActionFunction::RunImpl() {
>  }
>
>  bool BrowserActionSetIconFunction::RunBrowserAction() {
> -  BinaryValue* binary = NULL;
> +  base::BinaryValue* binary = NULL;
>   EXTENSION_FUNCTION_VALIDATE(details_->GetBinary("imageData", &binary));
>   IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());
>   void* iter = NULL;
> Index: chrome/browser/extensions/extension_page_actions_module.cc
> diff --git a/chrome/browser/extensions/extension_page_actions_module.cc
> b/chrome/browser/extensions/extension_page_actions_module.cc
> index
>
4d245b4c1c0bcb62d2f494e5d64b88f1dfce7a44..bdd9c683806f619e4bfb1aabfa6c25e93cd3c354
> 100644
> --- a/chrome/browser/extensions/extension_page_actions_module.cc
> +++ b/chrome/browser/extensions/extension_page_actions_module.cc
> @@ -155,7 +155,7 @@ bool PageActionSetIconFunction::RunImpl() {
>
>   // setIcon can take a variant argument: either a canvas ImageData, or an
>   // icon index.
> -  BinaryValue* binary;
> +  base::BinaryValue* binary;
>   int icon_index;
>   if (args->GetBinary("imageData", &binary)) {
>     IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());
> Index: chrome/browser/extensions/extension_sidebar_api.cc
> diff --git a/chrome/browser/extensions/extension_sidebar_api.cc
> b/chrome/browser/extensions/extension_sidebar_api.cc
> index
>
d4fca76c41d05ea7b1a5cdfad7a339fab6ebbacb..2b81d40b0e6204c74da8330d885bfbe8211c8272
> 100644
> --- a/chrome/browser/extensions/extension_sidebar_api.cc
> +++ b/chrome/browser/extensions/extension_sidebar_api.cc
> @@ -229,7 +229,7 @@ bool SetBadgeTextSidebarFunction::RunImpl(TabContents*
> tab,
>  bool SetIconSidebarFunction::RunImpl(TabContents* tab,
>                                      const std::string& content_id,
>                                      const DictionaryValue& details) {
> -  BinaryValue* binary;
> +  base::BinaryValue* binary;
>   EXTENSION_FUNCTION_VALIDATE(details.GetBinary(kImageDataKey, &binary));
>   IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());
>   void* iter = NULL;
> Index: chrome/browser/policy/user_policy_cache.cc
> diff --git a/chrome/browser/policy/user_policy_cache.cc
> b/chrome/browser/policy/user_policy_cache.cc
> index
>
838757b70b17d9169c398897af9c2f8d1b05891b..e0e0504e512234c81a90f4dcdcb9c54e9ed1ce36
> 100644
> --- a/chrome/browser/policy/user_policy_cache.cc
> +++ b/chrome/browser/policy/user_policy_cache.cc
> @@ -201,7 +201,8 @@ Value* UserPolicyCache::DecodeValue(const
> em::GenericValue& value) const {
>     case em::GenericValue::VALUE_TYPE_BYTES:
>       if (value.has_bytes_value()) {
>         std::string bytes = value.bytes_value();
> -        return BinaryValue::CreateWithCopiedBuffer(bytes.c_str(),
> bytes.size());
> +        return base::BinaryValue::CreateWithCopiedBuffer(bytes.c_str(),
> +                                                         bytes.size());
>       }
>       return NULL;
>     case em::GenericValue::VALUE_TYPE_BOOL_ARRAY: {
> Index: chrome/renderer/extensions/extension_process_bindings.cc
> diff --git a/chrome/renderer/extensions/extension_process_bindings.cc
> b/chrome/renderer/extensions/extension_process_bindings.cc
> index
>
b518c9bd0a2b7309d2bb8ce82ebc98d144d031c2..7aa059bdae53ddcd78ccbe95b05ce33cfd1c7a1c
> 100644
> --- a/chrome/renderer/extensions/extension_process_bindings.cc
> +++ b/chrome/renderer/extensions/extension_process_bindings.cc
> @@ -515,7 +515,7 @@ class ExtensionImpl : public ExtensionBase {
>     // Construct the Value object.
>     IPC::Message bitmap_pickle;
>     IPC::WriteParam(&bitmap_pickle, bitmap);
> -    *bitmap_value = BinaryValue::CreateWithCopiedBuffer(
> +    *bitmap_value = base::BinaryValue::CreateWithCopiedBuffer(
>         static_cast<const char*>(bitmap_pickle.data()),
> bitmap_pickle.size());
>
>     return true;
> Index: ipc/ipc_message_utils.cc
> diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
> index
>
9492a1110781f68bfc04c173108825993c3cfd79..29ca11e1eddb7474e781ffd4e6b42417e1e46a2c
> 100644
> --- a/ipc/ipc_message_utils.cc
> +++ b/ipc/ipc_message_utils.cc
> @@ -62,7 +62,8 @@ static void WriteValue(Message* m, const Value* value, int
> recursion) {
>       break;
>     }
>     case Value::TYPE_BINARY: {
> -      const BinaryValue* binary = static_cast<const BinaryValue*>(value);
> +      const base::BinaryValue* binary =
> +          static_cast<const base::BinaryValue*>(value);
>       m->WriteData(binary->GetBuffer(),
> static_cast<int>(binary->GetSize()));
>       break;
>     }
> @@ -185,7 +186,7 @@ static bool ReadValue(const Message* m, void** iter,
> Value** value,
>       int length;
>       if (!m->ReadData(iter, &data, &length))
>         return false;
> -      *value = BinaryValue::CreateWithCopiedBuffer(data, length);
> +      *value = base::BinaryValue::CreateWithCopiedBuffer(data, length);
>       break;
>     }
>     case Value::TYPE_DICTIONARY: {
>
>
>

[tfarina, 2011-08-05 16:28:40]

On Fri, Aug 5, 2011 at 4:11 AM, Evan Martin <evan@chromium.org> wrote:
> There's a thread about this on chromium-dev right now.  Did we reach a
> conclusion?
>
Sorry, I didn't find the thread. Do you have a link for it?

-- 
Thiago

[Evan Martin, 2011-08-05 17:09:36]

On Fri, Aug 5, 2011 at 9:28 AM, Thiago Farina <tfarina@chromium.org> wrote:
> On Fri, Aug 5, 2011 at 4:11 AM, Evan Martin <evan@chromium.org> wrote:
>> There's a thread about this on chromium-dev right now.  Did we reach a
>> conclusion?
>>
> Sorry, I didn't find the thread. Do you have a link for it?

http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

[tfarina, 2011-08-05 17:24:54]

On Fri, Aug 5, 2011 at 2:09 PM, Evan Martin <evan@chromium.org> wrote:
> On Fri, Aug 5, 2011 at 9:28 AM, Thiago Farina <tfarina@chromium.org> wrote:
>> On Fri, Aug 5, 2011 at 4:11 AM, Evan Martin <evan@chromium.org> wrote:
>>> There's a thread about this on chromium-dev right now.  Did we reach a
>>> conclusion?
>>>
>> Sorry, I didn't find the thread. Do you have a link for it?
>
>
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...
>
Ah, right, but my patch doesn't have anything related to it (or
have?). At least it doesn't affect it in any way, as far as I can see.

Is it implicit in the thread that BinaryValue shouldn't exist at first
place? Is it about this you are referring?

-- 
Thiago

[Evan Martin, 2011-08-05 17:32:00]

I am sorry!  I misread the code description.  (I thought you were deleting
BinaryValue, but you are just deleting the "using" declaration!)

LGTM

[Evan Martin, 2011-08-05 17:32:13]

LGTM again (misclicked and didn't send mail)