[Sync] Add passphrase/encryption info to chrome://sync.

[Sync] Add passphrase/encryption info to chrome://sync.

BUG=91134
TEST=Set up sync, inspect chrome://sync


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95536

[akalin, 2011-08-03 19:10:02]

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2126:
allstatus_.SetEncryptEverything(newly_encrypted_types.size() >
Can we instead expose the list of encrypted types?  More information = better

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2569:
allstatus_.SetCryptographerReady(false);
seems less brittle to, e.g. set cryptographerready to 'false' outside of the
block, then set it to ready only in the else statement.

[Nicolas Zea, 2011-08-03 22:04:24]

PTAL. I went ahead and just used ModelTypeSetToString since the JSON writer
wasn't really necessary. It doesn't really mess up the view. As we discussed, we
can make this more elegant at a later date.

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2126:
allstatus_.SetEncryptEverything(newly_encrypted_types.size() >
On 2011/08/03 19:10:02, akalin wrote:
> Can we instead expose the list of encrypted types?  More information = better

Done.

http://codereview.chromium.org/7550023/diff/1001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2569:
allstatus_.SetCryptographerReady(false);
On 2011/08/03 19:10:02, akalin wrote:
> seems less brittle to, e.g. set cryptographerready to 'false' outside of the
> block, then set it to ready only in the else statement.

Done.

[akalin, 2011-08-04 01:14:47]

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/a...
File chrome/browser/sync/engine/all_status.cc (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/a...
chrome/browser/sync/engine/all_status.cc:23: status_.cryptographer_ready =
false;
crypto has pending keys?

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:1645: : summary(INVALID) {
All the vars are initialized by allstatus right?  So there's no need to
initialize summary here.  Alternatively, you could move all the init code from
allstatus into here.

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2578: syncable::ModelTypeSet
encrypted_types =
seems clearer to inline the call to GetEncryptedTypes() (since it parallels the
ones above)

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.h:755: std::string encrypted_types;
I'd prefer storing it here as a ModelTypeSet/BitSet and converting it to a
string in sync_ui_util

[Nicolas Zea, 2011-08-04 01:27:51]

Done. PTAL

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/a...
File chrome/browser/sync/engine/all_status.cc (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/a...
chrome/browser/sync/engine/all_status.cc:23: status_.cryptographer_ready =
false;
On 2011/08/04 01:14:48, akalin wrote:
> crypto has pending keys?

Done.

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:1645: : summary(INVALID) {
On 2011/08/04 01:14:48, akalin wrote:
> All the vars are initialized by allstatus right?  So there's no need to
> initialize summary here.  Alternatively, you could move all the init code from
> allstatus into here.

Done.

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.cc:2578: syncable::ModelTypeSet
encrypted_types =
On 2011/08/04 01:14:48, akalin wrote:
> seems clearer to inline the call to GetEncryptedTypes() (since it parallels
the
> ones above)

Done.

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/7550023/diff/4002/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.h:755: std::string encrypted_types;
On 2011/08/04 01:14:48, akalin wrote:
> I'd prefer storing it here as a ModelTypeSet/BitSet and converting it to a
> string in sync_ui_util

Done.

[Nicolas Zea, 2011-08-04 19:54:56]

ping!

[akalin, 2011-08-04 22:02:04]

LGTM

[akalin, 2011-08-04 22:02:23]

On 2011/08/04 22:02:04, akalin wrote:
> LGTM

Checking commit box

[commit-bot: I haz the power, 2011-08-04 23:42:43]

Change committed as 95536