Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: chrome/browser/resources/print_preview/page_settings.js

Issue 7550022: Print Preview: Fixing behavior of event listeners. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding function commetns Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/page_settings.js
diff --git a/chrome/browser/resources/print_preview/page_settings.js b/chrome/browser/resources/print_preview/page_settings.js
index 48210c64dc0c8d3a2f80361c9c3fbdb7357cf6ba..a0c36d0701f38d3fc5d444cc52e13687661d0603 100644
--- a/chrome/browser/resources/print_preview/page_settings.js
+++ b/chrome/browser/resources/print_preview/page_settings.js
@@ -322,13 +322,12 @@ cr.define('print_preview', function() {
* |this.selectedPagesTextfield|. Ensures that
* |this.selectedPagesTextfield| is non-empty before checking
* |this.selectedPagesRadioButton|.
+ * @private
*/
- onSelectedPagesTextfieldInput: function() {
+ onSelectedPagesTextfieldInput_: function() {
if (this.selectedPagesText.length)
this.selectedPagesRadioButton.checked = true;
- if (!hasPendingPreviewRequest) {
- this.resetSelectedPagesTextfieldTimer_();
- }
+ this.resetSelectedPagesTextfieldTimer_();
},
/**
@@ -336,25 +335,14 @@ cr.define('print_preview', function() {
* of altering their behavior depending on |hasPendingPreviewRequest|.
*/
addEventListeners: function() {
- this.allPagesRadioButton.onclick = function() {
- if (hasPendingPreviewRequest)
- cr.dispatchSimpleEvent(document, 'updatePrintButton');
- else
- this.onSelectedPagesMayHaveChanged_();
- }.bind(this);
-
- this.selectedPagesRadioButton.onclick = function() {
- if (!hasPendingPreviewRequest)
- this.onSelectedPagesMayHaveChanged_();
- }.bind(this);
-
+ this.allPagesRadioButton.onclick =
+ this.onSelectedPagesMayHaveChanged_.bind(this);
+ this.selectedPagesRadioButton.onclick =
+ this.onSelectedPagesMayHaveChanged_.bind(this);
this.selectedPagesTextfield.oninput =
- this.onSelectedPagesTextfieldInput.bind(this);
-
- this.selectedPagesTextfield.onfocus = function() {
- if (!hasPendingPreviewRequest)
- this.addTimerToSelectedPagesTextfield_();
- }.bind(this);
+ this.onSelectedPagesTextfieldInput_.bind(this);
+ this.selectedPagesTextfield.onfocus =
+ this.addTimerToSelectedPagesTextfield_.bind(this);
// Handler for the blur event on |this.selectedPagesTextfield|. Un-checks
// |this.selectedPagesRadioButton| if the input field is empty.
@@ -362,13 +350,8 @@ cr.define('print_preview', function() {
if (!this.selectedPagesText.length)
this.allPagesRadioButton_.checked = true;
- if (hasPendingPreviewRequest) {
- this.validateSelectedPages_();
- cr.dispatchSimpleEvent(document, 'updatePrintButton');
- } else {
- clearTimeout(this.timerId_);
- this.onSelectedPagesMayHaveChanged_();
- }
+ clearTimeout(this.timerId_);
+ this.onSelectedPagesMayHaveChanged_();
}.bind(this);
}
};

Powered by Google App Engine
This is Rietveld 408576698