Print Preview: Fixing behavior of event listeners.

chrome/browser/ui/webui/print_preview_ui.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_UI_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/time.h"
 #include "chrome/browser/printing/print_preview_data_service.h"
 #include "chrome/browser/ui/webui/chrome_web_ui.h"
 
 class PrintPreviewDataService;
 class PrintPreviewHandler;
+struct PrintHostMsg_DidGetPreviewPageCount_Params;
 
 class PrintPreviewUI : public ChromeWebUI {
  public:
   explicit PrintPreviewUI(TabContents* contents);
   virtual ~PrintPreviewUI();
 
   // Gets the print preview |data|. |index| is zero-based, and can be
   // |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to get the entire preview
   // document.
   void GetPrintPreviewDataForIndex(int index,
                                    scoped_refptr<RefCountedBytes>* data);
 
   // Sets the print preview |data|. |index| is zero-based, and can be
   // |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to set the entire preview
   // document.
   void SetPrintPreviewDataForIndex(int index, const RefCountedBytes* data);
 
   // Clear the existing print preview data.
   void ClearAllPreviewData();
 
   // Notify the Web UI that there is a print preview request.
   // There should be a matching call to OnPreviewDataIsAvailable() or
   // OnPrintPreviewFailed().
   void OnPrintPreviewRequest();
 
-  // Notify the Web UI that the print preview will have |page_count| pages.
-  // |is_modifiable| indicates if the preview can be rerendered with different
-  // print settings.
-  void OnDidGetPreviewPageCount(int document_cookie_,
-                                int page_count,
-                                bool is_modifiable);
+  // Notify the Web UI that the print preview will have |params.page_count|
+  // pages. |params.is_modifiable| indicates if the preview can be rerendered

[kmadhusu, 2011/08/10 17:12:40]

nit: I think the struct definition has a detailed description about the member
variables. We don't want to repeat that here.

[dpapad, 2011/08/10 17:21:40]

Done. Removed the details from this comment.

+  // with different print settings. |params.preview_request_id| indicates wich
+  // request resulted in this response.
+  void OnDidGetPreviewPageCount(
+      const PrintHostMsg_DidGetPreviewPageCount_Params& params);
 
   // Notify the Web UI that the 0-based page |page_number| has been rendered.
-  void OnDidPreviewPage(int page_number);
+  // |preview_request_id| indicates wich request resulted in this response.
+  void OnDidPreviewPage(int page_number, int preview_request_id);
 
   // Notify the Web UI renderer that preview data is available.
   // |expected_pages_count| specifies the total number of pages.
   // |job_title| is the title of the page being previewed.
   // |preview_request_id| indicates wich request resulted in this response.
   void OnPreviewDataIsAvailable(int expected_pages_count,
                                 const string16& job_title,
                                 int preview_request_id);
 
   void OnReusePreviewData(int preview_request_id);
@@ skipping 40 matching lines @@
   // The number of print preview requests in flight.
   uint32 request_count_;
 
   // Document cookie from the initiator renderer.
   int document_cookie_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewUI);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_UI_H_