Print Preview: Fixing behavior of event listeners.

chrome/browser/resources/print_preview/print_preview_utils.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Returns true if |toTest| contains only digits. Leading and trailing
  * whitespace is allowed.
  * @param {string} toTest The string to be tested.
  */
 function isInteger(toTest) {
@@ skipping 171 matching lines @@
 
 /**
  * Constructs a url for getting a specific page.
  * @param {string} id The id of the preview data.
  * @param {number} pageNumber The number of the desired page.
  * @return {string} The constructed URL.
  */
 function getPageSrcURL(id, pageNumber) {
   return 'chrome://print/' + id + '/' + pageNumber + '/print.pdf';
 }
+
+
+/**
+ * Returns a random integer within the specified range, |endPointA| and
+ * |endPointB| are included.
+ * @param {number} endPointA One end of the desired range.
+ * @param {number} endPointB  The other end of the desired range.
+ * @return {number} The random integer.
+ */
+function getRandomIntegerWithinRange(endPointA, endPointB) {

[Lei Zhang, 2011/08/10 03:26:07]

I think most people call this function "randInt()".

[dpapad, 2011/08/10 15:47:10]

Renamed to randomInteger() instead of randInt(). According to the C++ styleguide
"Function names, variable names, and filenames should be descriptive; eschew
abbreviation". I think it is a good practice to apply in JS too.

+  from = Math.min(endPointA, endPointB);
+  to = Math.max(endPointA, endPointB);
+  return Math.floor(Math.random() * (to - from + 1) + from);
+}