Print Preview: Fixing behavior of event listeners.

chrome/browser/resources/print_preview/page_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a PageSettings object. This object encapsulates all settings and
    * logic related to page selection.
@@ skipping 304 matching lines @@
      */
     onSelectedPagesRadioButtonChecked_: function() {
       this.selectedPagesTextfield_.focus();
     },
 
     /**
      * Listener executing when an input event occurs in
      * |this.selectedPagesTextfield|. Ensures that
      * |this.selectedPagesTextfield| is non-empty before checking
      * |this.selectedPagesRadioButton|.
+     * @private
      */
-    onSelectedPagesTextfieldInput: function() {
+    onSelectedPagesTextfieldInput_: function() {
       if (this.selectedPagesText.length)
         this.selectedPagesRadioButton.checked = true;
-      if (!hasPendingPreviewRequest) {
-        this.resetSelectedPagesTextfieldTimer_();
-      }
+      this.resetSelectedPagesTextfieldTimer_();
     },
 
     /**
      * Adding listeners to all pages related controls. The listeners take care
      * of altering their behavior depending on |hasPendingPreviewRequest|.
      */
     addEventListeners: function() {
-      this.allPagesRadioButton.onclick = function() {
-        if (hasPendingPreviewRequest)
-          cr.dispatchSimpleEvent(document, 'updatePrintButton');
-        else
-          this.onSelectedPagesMayHaveChanged_();
-      }.bind(this);
-
-      this.selectedPagesRadioButton.onclick = function() {
-        if (!hasPendingPreviewRequest)
-          this.onSelectedPagesMayHaveChanged_();
-      }.bind(this);
-
+      this.allPagesRadioButton.onclick =
+          this.onSelectedPagesMayHaveChanged_.bind(this);
+      this.selectedPagesRadioButton.onclick =
+          this.onSelectedPagesMayHaveChanged_.bind(this);
       this.selectedPagesTextfield.oninput =
-          this.onSelectedPagesTextfieldInput.bind(this);
-
-      this.selectedPagesTextfield.onfocus = function() {
-        if (!hasPendingPreviewRequest)
-          this.addTimerToSelectedPagesTextfield_();
-      }.bind(this);
+          this.onSelectedPagesTextfieldInput_.bind(this);
+      this.selectedPagesTextfield.onfocus =
+          this.addTimerToSelectedPagesTextfield_.bind(this);
 
       // Handler for the blur event on |this.selectedPagesTextfield|. Un-checks
       // |this.selectedPagesRadioButton| if the input field is empty.
       this.selectedPagesTextfield.onblur = function() {
         if (!this.selectedPagesText.length)
           this.allPagesRadioButton_.checked = true;
 
-        if (hasPendingPreviewRequest) {
-          this.validateSelectedPages_();
-          cr.dispatchSimpleEvent(document, 'updatePrintButton');
-        } else {
-          clearTimeout(this.timerId_);
-          this.onSelectedPagesMayHaveChanged_();
-        }
+        clearTimeout(this.timerId_);
+        this.onSelectedPagesMayHaveChanged_();
       }.bind(this);
     }
   };
 
   return {
     PageSettings: PageSettings,
   };
 });