Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 7550022: Print Preview: Fixing behavior of event listeners. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing kmadhusu's comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/print_preview_message_handler.h" 5 #include "chrome/browser/printing/print_preview_message_handler.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/ref_counted_memory.h" 10 #include "base/memory/ref_counted_memory.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 printing::PrintPreviewTabController::GetInstance(); 73 printing::PrintPreviewTabController::GetInstance();
74 if (!tab_controller) 74 if (!tab_controller)
75 return NULL; 75 return NULL;
76 return tab_controller->GetPrintPreviewForTab(tab_contents()); 76 return tab_controller->GetPrintPreviewForTab(tab_contents());
77 } 77 }
78 78
79 void PrintPreviewMessageHandler::OnRequestPrintPreview() { 79 void PrintPreviewMessageHandler::OnRequestPrintPreview() {
80 PrintPreviewTabController::PrintPreview(tab_contents()); 80 PrintPreviewTabController::PrintPreview(tab_contents());
81 } 81 }
82 82
83 void PrintPreviewMessageHandler::OnDidGetPreviewPageCount(int document_cookie, 83 void PrintPreviewMessageHandler::OnDidGetPreviewPageCount(
84 int page_count, 84 const PrintHostMsg_DidGetPreviewPageCount_Params& params) {
85 bool is_modifiable) { 85 if (params.page_count <= 0)
86 if (page_count <= 0)
87 return; 86 return;
88 TabContents* print_preview_tab = GetPrintPreviewTab(); 87 TabContents* print_preview_tab = GetPrintPreviewTab();
89 if (!print_preview_tab) 88 if (!print_preview_tab)
90 return; 89 return;
91 90
92 PrintPreviewUI* print_preview_ui = 91 PrintPreviewUI* print_preview_ui =
93 static_cast<PrintPreviewUI*>(print_preview_tab->web_ui()); 92 static_cast<PrintPreviewUI*>(print_preview_tab->web_ui());
94 print_preview_ui->OnDidGetPreviewPageCount( 93 print_preview_ui->OnDidGetPreviewPageCount(params);
95 document_cookie, page_count, is_modifiable);
96 } 94 }
97 95
98 void PrintPreviewMessageHandler::OnDidPreviewPage( 96 void PrintPreviewMessageHandler::OnDidPreviewPage(
99 const PrintHostMsg_DidPreviewPage_Params& params) { 97 const PrintHostMsg_DidPreviewPage_Params& params) {
100 RenderViewHost* rvh = tab_contents()->render_view_host(); 98 RenderViewHost* rvh = tab_contents()->render_view_host();
101 TabContents* print_preview_tab = GetPrintPreviewTab(); 99 TabContents* print_preview_tab = GetPrintPreviewTab();
102 if (!(print_preview_tab && print_preview_tab->web_ui())) { 100 if (!(print_preview_tab && print_preview_tab->web_ui())) {
103 // Can't find print preview tab means we should abort. 101 // Can't find print preview tab means we should abort.
104 rvh->Send(new PrintMsg_AbortPreview(rvh->routing_id())); 102 rvh->Send(new PrintMsg_AbortPreview(rvh->routing_id()));
105 return; 103 return;
(...skipping 15 matching lines...) Expand all
121 119
122 if (page_number == FIRST_PAGE_INDEX) 120 if (page_number == FIRST_PAGE_INDEX)
123 print_preview_ui->ClearAllPreviewData(); 121 print_preview_ui->ClearAllPreviewData();
124 122
125 if (page_number >= FIRST_PAGE_INDEX && params.data_size) { 123 if (page_number >= FIRST_PAGE_INDEX && params.data_size) {
126 RefCountedBytes* data_bytes = 124 RefCountedBytes* data_bytes =
127 GetDataFromHandle(params.metafile_data_handle, params.data_size); 125 GetDataFromHandle(params.metafile_data_handle, params.data_size);
128 DCHECK(data_bytes); 126 DCHECK(data_bytes);
129 127
130 print_preview_ui->SetPrintPreviewDataForIndex(page_number, data_bytes); 128 print_preview_ui->SetPrintPreviewDataForIndex(page_number, data_bytes);
131 print_preview_ui->OnDidPreviewPage(page_number); 129 print_preview_ui->OnDidPreviewPage(page_number, params.preview_request_id);
132 // TODO(kmadhusu): Query |PrintPreviewUI| and update 130 // TODO(kmadhusu): Query |PrintPreviewUI| and update
133 // |requested_preview_page_index| accordingly. 131 // |requested_preview_page_index| accordingly.
134 } 132 }
135 133
136 rvh->Send(new PrintMsg_ContinuePreview(rvh->routing_id(), 134 rvh->Send(new PrintMsg_ContinuePreview(rvh->routing_id(),
137 requested_preview_page_index)); 135 requested_preview_page_index));
138 } 136 }
139 137
140 void PrintPreviewMessageHandler::OnPagesReadyForPreview( 138 void PrintPreviewMessageHandler::OnPagesReadyForPreview(
141 const PrintHostMsg_DidPreviewDocument_Params& params) { 139 const PrintHostMsg_DidPreviewDocument_Params& params) {
142 StopWorker(params.document_cookie); 140 StopWorker(params.document_cookie);
143 141
144 // Get the print preview tab. 142 // Get the print preview tab.
145 TabContents* print_preview_tab = GetPrintPreviewTab(); 143 TabContents* print_preview_tab = GetPrintPreviewTab();
146 // User might have closed it already. 144 // User might have closed it already.
147 if (!print_preview_tab) 145 if (!print_preview_tab)
148 return; 146 return;
149 147
150 PrintPreviewUI* print_preview_ui = 148 PrintPreviewUI* print_preview_ui =
151 static_cast<PrintPreviewUI*>(print_preview_tab->web_ui()); 149 static_cast<PrintPreviewUI*>(print_preview_tab->web_ui());
152 150
153 TabContentsWrapper* wrapper = 151 TabContentsWrapper* wrapper =
154 TabContentsWrapper::GetCurrentWrapperForContents(print_preview_tab); 152 TabContentsWrapper::GetCurrentWrapperForContents(print_preview_tab);
155 153
156 if (params.reuse_existing_data) { 154 if (params.reuse_existing_data) {
157 // Need to match normal rendering where we are expected to send this. 155 // Need to match normal rendering where we are expected to send this.
158 print_preview_ui->OnDidGetPreviewPageCount(params.document_cookie, 156 PrintHostMsg_DidGetPreviewPageCount_Params temp_params;
159 params.expected_pages_count, 157 temp_params.page_count = params.expected_pages_count;
160 params.modifiable); 158 temp_params.document_cookie = params.document_cookie;
161 159 temp_params.is_modifiable = params.modifiable;
160 temp_params.preview_request_id = params.preview_request_id;
161 print_preview_ui->OnDidGetPreviewPageCount(temp_params);
162 print_preview_ui->OnReusePreviewData(params.preview_request_id); 162 print_preview_ui->OnReusePreviewData(params.preview_request_id);
163 return; 163 return;
164 } 164 }
165 165
166 wrapper->print_view_manager()->OverrideTitle(tab_contents()); 166 wrapper->print_view_manager()->OverrideTitle(tab_contents());
167 167
168 // TODO(joth): This seems like a good match for using RefCountedStaticMemory 168 // TODO(joth): This seems like a good match for using RefCountedStaticMemory
169 // to avoid the memory copy, but the SetPrintPreviewData call chain below 169 // to avoid the memory copy, but the SetPrintPreviewData call chain below
170 // needs updating to accept the RefCountedMemory* base class. 170 // needs updating to accept the RefCountedMemory* base class.
171 RefCountedBytes* data_bytes = 171 RefCountedBytes* data_bytes =
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 } 225 }
226 226
227 void PrintPreviewMessageHandler::DidStartLoading() { 227 void PrintPreviewMessageHandler::DidStartLoading() {
228 if (tab_contents()->delegate() && 228 if (tab_contents()->delegate() &&
229 printing::PrintPreviewTabController::IsPrintPreviewTab(tab_contents())) { 229 printing::PrintPreviewTabController::IsPrintPreviewTab(tab_contents())) {
230 tab_contents()->SetContentRestrictions(CONTENT_RESTRICTION_PRINT); 230 tab_contents()->SetContentRestrictions(CONTENT_RESTRICTION_PRINT);
231 } 231 }
232 } 232 }
233 233
234 } // namespace printing 234 } // namespace printing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698