Print Preview: Fixing behavior of event listeners.

chrome/browser/resources/print_preview/print_preview_utils.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Returns true if |toTest| contains only digits. Leading and trailing
  * whitespace is allowed.
  * @param {string} toTest The string to be tested.
  */
 function isInteger(toTest) {
@@ skipping 171 matching lines @@
 
 /**
  * Constructs a url for getting a specific page.
  * @param {string} id The id of the preview data.
  * @param {number} pageNumber The number of the desired page.
  * @return {string} The constructed URL.
  */
 function getPageSrcURL(id, pageNumber) {
   return 'chrome://print/' + id + '/' + pageNumber + '/print.pdf';
 }
+
+
+/**
+ * Returns a random integer within the specified range, |from| and |to| are
+ * included.
+ * @param {number} from Start of the range.
+ * @param {number} to  End of the range.
+ * @return {number} The random integer.
+ */
+function getRandomIntegerWithinRange(from, to) {

[kmadhusu, 2011/08/09 22:30:40]

This function can return negative value. Please validate from & to and make sure
Math.floor returns a positive integer. 

[dpapad, 2011/08/10 00:17:11]

This function does what it says in the documentation. It can return negative
numbers if |from| is negative. It is up to the caller to use it appropriately.
Why constraining it to return a positive integer?

I did fix it though so that the order of arguments does not matter
(getRandomIntegerWithinRange(0,10) and getRandomIntegerWithinRange(10,0) both
work as expected now).
I am also planning to a new test for this function.

+  return Math.floor(Math.random() * (to - from + 1) + from);
+}