Print Preview: Fixing behavior of event listeners.

chrome/browser/resources/print_preview/layout_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a LayoutSettings object. This object encapsulates all settings and
    * logic related to layout mode (portrait/landscape).
@@ skipping 30 matching lines @@
      */
     isLandscape: function() {
       return this.landscapeRadioButton_.checked;
     },
 
     /**
      * Adding listeners to all layout related controls. The listeners take care
      * of altering their behavior depending on |hasPendingPreviewRequest|.
      */
     addEventListeners: function() {
       this.landscapeRadioButton_.onclick = function() {

[kmadhusu, 2011/08/08 22:20:45]

How about:
this.landscapeRadioButton_.onclick = this.onLayoutButtonClick_().bind(this); ? 

It will be consistent with page_settings.js line #338.

[dpapad, 2011/08/08 23:41:43]

Done.

-        if (!hasPendingPreviewRequest)
-          this.onLayoutButtonClick_();
+        this.onLayoutButtonClick_();
       }.bind(this);
       this.portraitRadioButton_.onclick = function() {
-        if (!hasPendingPreviewRequest)
-          this.onLayoutButtonClick_();
+        this.onLayoutButtonClick_();
       }.bind(this);
       document.addEventListener('PDFLoaded', this.onPDFLoaded_.bind(this));
       document.addEventListener('printerCapabilitiesUpdated',
                                 this.onPrinterCapabilitiesUpdated_.bind(this));
     },
 
     /**
      * Listener triggered when a printerCapabilitiesUpdated event occurs.
      * @private
      */
@@ skipping 12 matching lines @@
       if (printSettings.isLandscape == this.isLandscape())
         return;
       setDefaultValuesAndRegeneratePreview();
     },
 
     /**
      * Listener executing when a PDFLoaded event occurs.
      * @private
      */
     onPDFLoaded_: function() {
-      if (!previewModifiable)
-        fadeOutElement(this.layoutOption_);
+      this.fadeInOut_(!previewModifiable);
     },
 
     /**
      * @param {boolean} fadeOut True if |this.layoutOption_| should be faded
      *     out, false if it should be faded in.
      * @private
      */
     fadeInOut_: function(fadeOut) {
       fadeOut ? fadeOutElement(this.layoutOption_) :
           fadeInElement(this.layoutOption_);
     }
   };
 
   return {
     LayoutSettings: LayoutSettings,
   };
 });