ntp4: record app launch source

chrome/browser/ui/webui/ntp/app_launcher_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/extension_app_api.h"
@@ skipping 84 matching lines @@
 
   // Callback for the "promoSeen" message.
   void HandlePromoSeen(const base::ListValue* args);
 
   // Callback for the "saveAppPageName" message.
   void HandleSaveAppPageName(const base::ListValue* args);
 
   // Callback for the "generateAppForLink" message.
   void HandleGenerateAppForLink(const base::ListValue* args);
 
+  // Callback for the "recordAppLaunchByURL" message.

[Rick Byers, 2011/08/03 14:41:11]

In my opinion, these function declaration comments don't really conform to the
Google style guide which requires that they "describe what the function does and
how to use it".  I'd suggest adding something like:
Given a URL  and an AppLaunchBucket (encoded as a string), records a launch of
the application with the specified URL, if any (otherwise does nothing).  

I'd also love to know here (if you can determine the answer easily) to what
extent the URL needs to match.  Do hash values matter in the match?  Eg., if I'm
using an application that has set a fragment identifier, then close it, then
re-open from the recently closed list, do I get a launch recorded?  What about
query parameters.  I know of some Google apps in particular that both redirect
to urls with different query params and also set the location hash.

Personally I believe we'd benefit from a better specified contract between the
C++ and JS portions of WebUI code (I've spent a bunch of time myself trying to
reverse engineer these contracts - in retrospect I probably should have updated
comments as I did it).

[Evan Stade, 2011/08/03 22:11:22]

done
the app for a given url is determined by the extensions system, I don't know the
details.

+  void HandleRecordAppLaunchByURL(const base::ListValue* args);
+
   // Register app launcher preferences.
   static void RegisterUserPrefs(PrefService* pref_service);
 
  private:
   // Records a web store launch in the appropriate histograms. |promo_active|
   // specifies if the web store promotion was active.
   static void RecordWebStoreLaunch(bool promo_active);
 
   // Records an app launch in the corresponding |bucket| of the app launch
   // histogram. |promo_active| specifies if the web store promotion was active.
@@ skipping 59 matching lines @@
   // refreshing. This is useful when making many batch updates to avoid flicker.
   bool ignore_changes_;
 
   // Hold state for favicon requests.
   CancelableRequestConsumerTSimple<WebApplicationInfo*> favicon_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(AppLauncherHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_