ntp4: record app launch source

chrome/browser/ui/webui/ntp/app_launcher_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/auto_reset.h"
@@ skipping 133 matching lines @@
   }
   value->SetInteger("app_launch_index", app_launch_index);
 
   int page_index = prefs->GetPageIndex(extension->id());
   if (page_index >= 0) {
     // Only provide a value if one is stored
     value->SetInteger("page_index", page_index);
   }
 }
 
+// TODO(estade): remove this. We record app launches via js calls rather than
+// pings for ntp4.
 // static
 bool AppLauncherHandler::HandlePing(Profile* profile, const std::string& path) {
   std::vector<std::string> params;
   base::SplitString(path, '+', &params);
 
   // Check if the user launched an app from the most visited or recently
   // closed sections.
   if (kPingLaunchAppByURL == params.at(0)) {
     CHECK(params.size() == 3);
     RecordAppLaunchByURL(
@@ skipping 20 matching lines @@
 
   if (is_web_store_ping) {
     RecordWebStoreLaunch(is_promo_active);
   }  else {
     CHECK(params.size() == 3);
     RecordAppLaunchByID(is_promo_active, ParseLaunchSource(params.at(2)));
   }
 
   return true;
 }
 

[Rick Byers, 2011/08/03 14:41:11]

Remove extra blank line

[Evan Stade, 2011/08/03 22:11:22]

Done.

+
 WebUIMessageHandler* AppLauncherHandler::Attach(WebUI* web_ui) {
   // TODO(arv): Add initialization code to the Apps store etc.
   return WebUIMessageHandler::Attach(web_ui);
 }
 
 void AppLauncherHandler::RegisterMessages() {
   web_ui_->RegisterMessageCallback("getApps",
       NewCallback(this, &AppLauncherHandler::HandleGetApps));
   web_ui_->RegisterMessageCallback("launchApp",
       NewCallback(this, &AppLauncherHandler::HandleLaunchApp));
   web_ui_->RegisterMessageCallback("setLaunchType",
       NewCallback(this, &AppLauncherHandler::HandleSetLaunchType));
   web_ui_->RegisterMessageCallback("uninstallApp",
       NewCallback(this, &AppLauncherHandler::HandleUninstallApp));
   web_ui_->RegisterMessageCallback("hideAppsPromo",
       NewCallback(this, &AppLauncherHandler::HandleHideAppsPromo));
   web_ui_->RegisterMessageCallback("createAppShortcut",
       NewCallback(this, &AppLauncherHandler::HandleCreateAppShortcut));
   web_ui_->RegisterMessageCallback("reorderApps",
       NewCallback(this, &AppLauncherHandler::HandleReorderApps));
   web_ui_->RegisterMessageCallback("setPageIndex",
       NewCallback(this, &AppLauncherHandler::HandleSetPageIndex));
   web_ui_->RegisterMessageCallback("promoSeen",
       NewCallback(this, &AppLauncherHandler::HandlePromoSeen));
   web_ui_->RegisterMessageCallback("saveAppPageName",
       NewCallback(this, &AppLauncherHandler::HandleSaveAppPageName));
   web_ui_->RegisterMessageCallback("generateAppForLink",
       NewCallback(this, &AppLauncherHandler::HandleGenerateAppForLink));
+  web_ui_->RegisterMessageCallback("recordAppLaunchByURL",
+      NewCallback(this, &AppLauncherHandler::HandleRecordAppLaunchByURL));
 }
 
 void AppLauncherHandler::Observe(int type,
                                  const NotificationSource& source,
                                  const NotificationDetails& details) {
   if (ignore_changes_)
     return;
 
   switch (type) {
     case chrome::NOTIFICATION_APP_NOTIFICATION_STATE_CHANGED: {
@@ skipping 244 matching lines @@
   // If the user pressed special keys when clicking, override the saved
   // preference for launch container.
   bool middle_button = (button == 1.0);
   WindowOpenDisposition disposition =
         disposition_utils::DispositionFromClick(middle_button, alt_key,
                                                 ctrl_key, meta_key, shift_key);
 
   if (extension_id != extension_misc::kWebStoreAppId) {
     RecordAppLaunchByID(promo_active_, launch_bucket);
     extensions_service_->apps_promo()->ExpireDefaultApps();
+  } else if (CommandLine::ForCurrentProcess()->HasSwitch(
+        switches::kNewTabPage4)) {
+    RecordWebStoreLaunch(promo_active_);
   }
 
   if (disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {
     // TODO(jamescook): Proper support for background tabs.
     Browser::OpenApplication(
         profile, extension, extension_misc::LAUNCH_TAB, disposition);
   } else if (disposition == NEW_WINDOW) {
     // Force a new window open.
     Browser::OpenApplication(
             profile, extension, extension_misc::LAUNCH_WINDOW, disposition);
@@ skipping 189 matching lines @@
     return;
   }
 
   // TODO(gbillock): get page thumb from thumbnail db/history svc?
   FaviconService::Handle h = favicon_service->GetFaviconForURL(
       launch_url, history::FAVICON, &favicon_consumer_,
       NewCallback(this, &AppLauncherHandler::OnFaviconForApp));
   favicon_consumer_.SetClientData(favicon_service, h, web_app.release());
 }
 
+void AppLauncherHandler::HandleRecordAppLaunchByURL(
+    const base::ListValue* args) {
+  std::string url;
+  CHECK(args->GetString(0, &url));
+  std::string source;
+  CHECK(args->GetString(1, &source));

[Rick Byers, 2011/08/03 14:41:11]

Curious why you're taking a string argument here and adding a TODO saying to
make it an int.  Isn't it trivial to just make it an int now (just need a cast
below instead of calling ParseLaunchSource)?

[Evan Stade, 2011/08/03 22:11:22]

Done.

+
+  RecordAppLaunchByURL(
+      web_ui_->GetProfile(), url, ParseLaunchSource(source));
+}
+
 void AppLauncherHandler::OnFaviconForApp(FaviconService::Handle handle,
                                          history::FaviconData data) {
   scoped_ptr<WebApplicationInfo> web_app(
       favicon_consumer_.GetClientDataForCurrentRequest());
   CHECK(!web_app->icons.empty());
   if (data.is_valid() && gfx::PNGCodec::Decode(data.image_data->front(),
                                                data.image_data->size(),
                                                &(web_app->icons[0].data))) {
     web_app->icons[0].url = GURL();
     web_app->icons[0].width = web_app->icons[0].data.width();
@@ skipping 155 matching lines @@
 
 void AppLauncherHandler::UninstallDefaultApps() {
   AppsPromo* apps_promo = extensions_service_->apps_promo();
   const ExtensionIdSet& app_ids = apps_promo->old_default_apps();
   for (ExtensionIdSet::const_iterator iter = app_ids.begin();
        iter != app_ids.end(); ++iter) {
     if (extensions_service_->GetExtensionById(*iter, true))
       extensions_service_->UninstallExtension(*iter, false, NULL);
   }
 }