WebUI TaskManager: make it default on Chrome OS

WebUI TaskManager: make it default on Chrome OS 

And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager. 
- TaskManagerBrowserTest.ShutdownWhileOpen 
- ExtensionApiTest.ProcessesVsTaskManager 
- PrerenderBrowserTest.PrerenderTaskManager 


BUG=chromium-os:13885
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95567

[yoshiki, 2011-08-02 05:36:02]

My previous CL http://codereview.chromium.org/7520011/ was reverted, because
included file "chrome/test/ui_test_utils.h" has been renamed and its compile was
failed.

I fixed the error. Please review the code.

[mazda, 2011-08-02 06:43:17]

LGTM

[xiyuan, 2011-08-02 18:16:06]

LGTM

[Paweł Hajdan Jr., 2011-08-02 20:13:34]

Drive-by with testing comments.

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest.cc:59:
TaskManagerBrowserTestUtil::WaitForResourceChange(target_count);
nit: Just get rid of those one-line methods and update the call places.

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest_util.cc:53: class
TaskManagerReadyListener : public NotificationObserver {
Any chance you can use something from ui_test_util like
WindowedNotificationObserver or WaitForNotification?

[yoshiki, 2011-08-03 06:06:22]

phajdan: Thank you for the advice and I changed the code. Can you review it?

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest.cc:59:
TaskManagerBrowserTestUtil::WaitForResourceChange(target_count);
On 2011/08/02 20:13:34, Paweł Hajdan Jr. wrote:
> nit: Just get rid of those one-line methods and update the call places.

Done.

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest_util.cc:53: class
TaskManagerReadyListener : public NotificationObserver {
On 2011/08/02 20:13:34, Paweł Hajdan Jr. wrote:
> Any chance you can use something from ui_test_util like
> WindowedNotificationObserver or WaitForNotification?

Done. Replaced it with TaskManagerReadyListener.

[Paweł Hajdan Jr., 2011-08-03 16:31:33]

http://codereview.chromium.org/7550004/diff/6001/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/6001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager_browsertest_util.cc:53: class
BackgroundContentsListener : public NotificationObserver {
I'm pretty sure this can be replaced by WindowedNotificationObserver. Feel free
to ping me on IM/irc if I missed something.

[yoshiki, 2011-08-03 18:17:46]

http://codereview.chromium.org/7550004/diff/6001/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/6001/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager_browsertest_util.cc:53: class
BackgroundContentsListener : public NotificationObserver {
Done. I forgot this.

On 2011/08/03 16:31:33, Paweł Hajdan Jr. wrote:
> I'm pretty sure this can be replaced by WindowedNotificationObserver. Feel
free
> to ping me on IM/irc if I missed something.

[Paweł Hajdan Jr., 2011-08-03 19:15:34]

http://codereview.chromium.org/7550004/diff/9002/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/9002/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager_browsertest_util.cc:83:
ui_test_utils::WindowedNotificationObserver observer(
Now this is a misuse of WindowedNotificationObserver. You should trigger the
action after instantiation and before Wait. Please read the comments in
ui_test_utils.h.

[yoshiki, 2011-08-04 00:13:55]

http://codereview.chromium.org/7550004/diff/9002/chrome/browser/task_manager/...
File chrome/browser/task_manager/task_manager_browsertest_util.cc (right):

http://codereview.chromium.org/7550004/diff/9002/chrome/browser/task_manager/...
chrome/browser/task_manager/task_manager_browsertest_util.cc:83:
ui_test_utils::WindowedNotificationObserver observer(
On 2011/08/03 19:15:34, Paweł Hajdan Jr. wrote:
> Now this is a misuse of WindowedNotificationObserver. You should trigger the
> action after instantiation and before Wait. Please read the comments in
> ui_test_utils.h.

Done.

[Paweł Hajdan Jr., 2011-08-04 18:00:14]

Code I commented in the drive-by LGTM. Thank you for additional work on making
it more solid.