Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 7549009: Don't use mprotect on Cygwin (Closed)

Created:
9 years, 4 months ago by piscisaureus
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't use mprotect on Cygwin as virtual memory is managed directly via WinAPI calls. Patch by Bert Belder. Committed: http://code.google.com/p/v8/source/detail?r=8793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/platform-cygwin.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
piscisaureus
9 years, 4 months ago (2011-08-02 16:04:19 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 4 months ago (2011-08-02 16:05:24 UTC) #2
LGTM

I'll land.

Powered by Google App Engine
This is Rietveld 408576698