Issue 7549001: PrintPreview: Remove |page_number| from StartPageForVectorCanvas function.

Issue 7549001: PrintPreview: Remove |page_number| from StartPageForVectorCanvas function. (Closed)

Created:
9 years, 4 months ago by kmadhusu

Modified:
9 years, 4 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

PrintPreview: Remove |page_number| from StartPageForVectorCanvas function and |page_slot| from PrintMsg_PrintPage_Params. We will not add preview pages to the complete metafile in out of order fashion. BUG=none TEST=print preview works after code changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95092

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : Fixed nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -67 lines)			Patch
M	chrome/common/print_messages.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	1	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	1 2	4 chunks	+4 lines, -8 lines	0 comments	Download
M	printing/emf_win.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/emf_win.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	printing/metafile.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	printing/pdf_metafile_cairo_linux.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/pdf_metafile_cairo_linux.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/pdf_metafile_cg_mac.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/pdf_metafile_cg_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_metafile_skia.h	View	1 2 3	2 chunks	+2 lines, -5 lines	0 comments	Download
M	printing/pdf_metafile_skia.cc	View		4 chunks	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM w/ nit. http://codereview.chromium.org/7549001/diff/4002/printing/pdf_metafile_skia.h File printing/pdf_metafile_skia.h (right): http://codereview.chromium.org/7549001/diff/4002/printing/pdf_metafile_skia.h#newcode75 printing/pdf_metafile_skia.h:75: static const int kNoOutstandingPage = -1; ...

9 years, 4 months ago (2011-08-02 01:56:20 UTC) #2

kmadhusu

9 years, 4 months ago (2011-08-02 02:00:31 UTC) #3

http://codereview.chromium.org/7549001/diff/4002/printing/pdf_metafile_skia.h
File printing/pdf_metafile_skia.h (right):

http://codereview.chromium.org/7549001/diff/4002/printing/pdf_metafile_skia.h...
printing/pdf_metafile_skia.h:75: static const int kNoOutstandingPage = -1;
On 2011/08/02 01:56:20, vandebo wrote:
> Missed this.

Done.

Expand Messages | Collapse Messages