Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4499)

Unified Diff: chrome/test/pyautolib/pyautolib.cc

Issue 7548024: Refactor: Make PyAuto InstallExtension() take a string. Delete dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment per nirnimesh. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/pyautolib/pyautolib.cc
diff --git a/chrome/test/pyautolib/pyautolib.cc b/chrome/test/pyautolib/pyautolib.cc
index 3db59eb2682ff41d710a798d67b91eb94770dbc7..62714cf2334fcf0f44f04141c94f5610343589aa 100644
--- a/chrome/test/pyautolib/pyautolib.cc
+++ b/chrome/test/pyautolib/pyautolib.cc
@@ -202,10 +202,10 @@ int PyUITestBase::GetBrowserWindowCount() {
return num_windows;
}
-std::string PyUITestBase::InstallExtension(const FilePath& crx_file,
+std::string PyUITestBase::InstallExtension(const std::string& extension_path,
bool with_ui) {
scoped_refptr<ExtensionProxy> proxy =
- automation()->InstallExtension(crx_file, with_ui);
+ automation()->InstallExtension(extension_path, with_ui);
std::string id;
if (!proxy.get() || !proxy.get()->GetId(&id))
return "";

Powered by Google App Engine
This is Rietveld 408576698