Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/common/automation_messages_internal.h

Issue 7548024: Refactor: Make PyAuto InstallExtension() take a string. Delete dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial commit. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/automation_messages_internal.h
diff --git a/chrome/common/automation_messages_internal.h b/chrome/common/automation_messages_internal.h
index 4502a24a0b847b61ab0f5852fafc14e423b4f4ae..1b4e6e123c78fb500f95d357381ede69337ad16f 100644
--- a/chrome/common/automation_messages_internal.h
+++ b/chrome/common/automation_messages_internal.h
@@ -1128,11 +1128,6 @@ IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_GetMetricEventDuration,
IPC_MESSAGE_ROUTED1(AutomationMsg_RequestGoToHistoryEntryOffset,
int) // numbers of entries (negative or positive)
-// Silently install the extension in the given crx file.
-IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_InstallExtension,
- FilePath /* full path to crx file */,
- AutomationMsg_ExtensionResponseValues)
-
// DEPRECATED MESSAGE - But we must leave this comment and message so as
// not to perturb line numbers (see comment at top of file re __LINE__).
IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_DeprecatedMessageTwo,
@@ -1300,10 +1295,10 @@ IPC_SYNC_MESSAGE_CONTROL2_2(AutomationMsg_SendJSONRequest,
std::string /* JSON response */,
bool /* success */)
-// Installs an extension from the crx file and returns its id.
-// On error, |extension handle| will be 0.
-IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_InstallExtensionAndGetHandle,
- FilePath /* full path to crx file */,
+// Installs an extension from a crx file or unpacked extension folder
+// and returns its id. On error, |extension handle| will be 0.
+IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_InstallExtension,
+ std::string /* full path to extension */,
Nirnimesh 2011/08/03 01:28:18 append: crx or unbundled
bool /* with UI */,
int /* extension handle */)
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | chrome/test/automation/automation_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698