Refactor: Make PyAuto InstallExtension() take a string. Delete dead code.

chrome/test/pyautolib/pyautolib.cc

Index: chrome/test/pyautolib/pyautolib.cc
diff --git a/chrome/test/pyautolib/pyautolib.cc b/chrome/test/pyautolib/pyautolib.cc
index 3db59eb2682ff41d710a798d67b91eb94770dbc7..d0788b5a274ca55ca6b6720f907831ae87a8205b 100644
--- a/chrome/test/pyautolib/pyautolib.cc
+++ b/chrome/test/pyautolib/pyautolib.cc
@@ -202,10 +202,15 @@ int PyUITestBase::GetBrowserWindowCount() {
   return num_windows;
 }
 
-std::string PyUITestBase::InstallExtension(const FilePath& crx_file,
+std::string PyUITestBase::InstallExtension(const std::string& extension_path,
                                            bool with_ui) {
+#if defined(OS_WIN)
+  FilePath extension_file_path = FilePath(ASCIIToWide(extension_path));
+#else
+  FilePath extension_file_path = FilePath(extension_path);
+#endif
   scoped_refptr<ExtensionProxy> proxy =
-      automation()->InstallExtension(crx_file, with_ui);
+      automation()->InstallExtension(FilePath(extension_file_path), with_ui);

[kkania, 2011/08/03 23:52:46]

no reason to copy the FilePath here

   std::string id;
   if (!proxy.get() || !proxy.get()->GetId(&id))
     return "";