Refactor: Make PyAuto InstallExtension() take a string. Delete dead code.

chrome/common/automation_messages_internal.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the IPC messages used by the automation interface.
 
 #include <string>
 #include <vector>
 
 #include "base/string16.h"
@@ skipping 1110 matching lines @@
 // Returns a metric event duration that was last recorded.  Returns -1 if the
 // event hasn't occurred yet.
 IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_GetMetricEventDuration,
                             std::string /* event_name */,
                             int /* duration ms */)
 
 // Sent by automation provider - go to history entry via automation.
 IPC_MESSAGE_ROUTED1(AutomationMsg_RequestGoToHistoryEntryOffset,
                     int)   // numbers of entries (negative or positive)
 
-// Silently install the extension in the given crx file.

[kkania, 2011/08/03 16:01:56]

Deprecate this instead, as seen below. Otherwise you change the line number and
break the perf tests and chromedriver.

-IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_InstallExtension,
-                            FilePath /* full path to crx file */,
-                            AutomationMsg_ExtensionResponseValues)
-
 // DEPRECATED MESSAGE - But we must leave this comment and message so as
 // not to perturb line numbers (see comment at top of file re __LINE__).
 IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_DeprecatedMessageTwo,
                             int,
                             int)
 
 // DEPRECATED MESSAGE - But we must leave this comment and message so as
 // not to perturb line numbers (see comment at top of file re __LINE__).
 // (intentionally blank line)
 // (intentionally blank line)
@@ skipping 147 matching lines @@
                             bool /* success */)
 
 // Generic pyauto pattern to help avoid future addition of
 // automation messages.
 IPC_SYNC_MESSAGE_CONTROL2_2(AutomationMsg_SendJSONRequest,
                             int /* browser_handle */,
                             std::string /* JSON request */,
                             std::string /* JSON response */,
                             bool /* success */)
 
-// Installs an extension from the crx file and returns its id.
-// On error, |extension handle| will be 0.
-IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_InstallExtensionAndGetHandle,
-                            FilePath     /* full path to crx file */,
-                            bool         /* with UI */,
-                            int          /* extension handle */)
+// Installs an extension from a crx file or unpacked extension folder
+// and returns its id. On error, |extension handle| will be 0.
+IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_InstallExtension,
+                            std::string /* full path to crx or unpacked dir */,

[kkania, 2011/08/03 16:01:56]

hmm, in chromedriver we just started depending on this message a few days ago
for installing extensions. We used this instead of creating a JSON one because
then our users would need to wait for 2 months to get the feature.

Changing this will break older chromedriver's ability to work with newer
chromes, and will break newer chromedriver's ability to work with the current
stable/beta builds until this change makes it there.

you need to modify chrome/test/webdriver/automation.cc too, which was modified a
few days ago to use this func.

I see that using a string makes it easier for python clients. However, it also
makes it slightly more difficult for c++ clients. Now we have to convert from
file paths <-> std::string.

Sorry to twist your arm a bit, but do you think you can make a new JSON call
instead of changing this? If you want, I'd be more than happy to do it myself.

[dtu, 2011/08/03 19:31:53]

I can move the string -> FilePath conversion into pyautolib.cc so it doesn't
affect this signature. Is the rename of this message okay, or do you need to
maintain the original name?

[kkania, 2011/08/03 20:25:34]

Renaming is an ok approach too.

+                            bool        /* with UI */,
+                            int         /* extension handle */)
 
 // Waits for the next extension test result. Sets |test result| as the
 // received result and |message| as any accompanying message with the
 // result, which could be the empty string.
 IPC_SYNC_MESSAGE_CONTROL0_2(AutomationMsg_WaitForExtensionTestResult,
                             bool         /* test result */,
                             std::string  /* message */)
 
 // Uninstalls an extension. On success |success| is true.
 IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_UninstallExtension,
@@ skipping 167 matching lines @@
 // Sent when the renderer has completed or canceled a client redirect for a
 // particular frame. This message may be sent multiple times for the same
 // redirect.
 IPC_MESSAGE_ROUTED1(AutomationMsg_DidCompleteOrCancelClientRedirect,
                     int64 /* frame_id */)
 
 
 // YOUR NEW MESSAGE MIGHT NOT BELONG HERE.
 // This is the section for renderer -> browser automation messages. If it is
 // an automation <-> browser message, put it above this section.