Profiles: Introduce AllProfilesAndSources().

Profiles: Introduce AllBrowserContextsAndSources().

Eventually, we need to remove all current instances of AllSources(). One by
one, they need to either changed to listen to a specific notification source,
or (in very few cases where we actually are listening for a global
notification) they need to work correctly in the presence of multiple profiles,
in which case they'll be turned to AllBrowserContextsAndSources().

This patch, in addition:
- Deletes more unused notifications.
- Changes a few AllSources() calls to listen to specific objects.

BUG=87457
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95469

[Elliot Glaysher, 2011-08-02 21:51:35]

The name AllProfilesAndSources() was picked as it doesn't contain the substring
"AllSources()" and it points out that we need to work in a multiprofile world
where there are actually very few Singletons.

http://codereview.chromium.org/7548022/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_resource_providers.cc (right):

http://codereview.chromium.org/7548022/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_resource_providers.cc:337:
NotificationService::AllProfilesAndSources());
In these cases, the TaskManager is a global singleton since it is not Profile
aware.

[Elliot Glaysher, 2011-08-02 21:52:12]

The name AllProfilesAndSources() was picked as it doesn't contain the substring
"AllSources()" and it points out that we need to work in a multiprofile world
where there are actually very few Singletons.

[jam, 2011-08-03 00:28:13]

I'm not the best reviewer for this, others like brett/darin can give more
enlightened feedback about profiles and notifications

[Elliot Glaysher, 2011-08-03 17:49:05]

Per jam@'s suggestion, redirecting the review to brettw@ and darin@.

[darin (slow to review), 2011-08-03 19:36:40]

LGTM

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
File content/common/notification_service.h (right):

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
content/common/notification_service.h:58: static Source<void>
AllProfilesAndSources() { return Source<void>(NULL); }
I see, so this is making the content/ module know about profiles :(

[jam, 2011-08-03 19:40:13]

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
File content/common/notification_service.h (right):

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
content/common/notification_service.h:58: static Source<void>
AllProfilesAndSources() { return Source<void>(NULL); }
On 2011/08/03 19:36:41, darin wrote:
> I see, so this is making the content/ module know about profiles :(

oh, just saw this. we definitely don't want that.

[jam, 2011-08-03 19:40:51]

Adding Avi, who's been spending a bit of time getting rid of knowledge about
profile from content.

[Avi (use Gerrit), 2011-08-03 19:48:47]

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
File content/common/notification_service.h (right):

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
content/common/notification_service.h:58: static Source<void>
AllProfilesAndSources() { return Source<void>(NULL); }
I've been just basically doing s/Profile/BrowserContext/. I'd be OK with
AllBrowserContextsAndSources.

[Elliot Glaysher, 2011-08-03 19:57:06]

Will do Avi's requested rename.

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
File content/common/notification_service.h (right):

http://codereview.chromium.org/7548022/diff/1/content/common/notification_ser...
content/common/notification_service.h:58: static Source<void>
AllProfilesAndSources() { return Source<void>(NULL); }
On 2011/08/03 19:36:41, darin wrote:
> I see, so this is making the content/ module know about profiles :(

Actually fixing this would either require making the NotificationService not be
a singleton and have all consumers subscribe on the correct NotificationService
OR otherwise depending on a third Context<ProfileSuperclass> and plumb that
throughout everything that currently used. There might be a third design.

As is, consumers of the NotificationService aren't being disciplined about
AllSources() usage and I'm doing this to mark places that I've manually checked
as being correct.

[commit-bot: I haz the power, 2011-08-04 19:56:51]

Change committed as 95469