Issue 7547001: Propagate connected user to web app.

Issue 7547001: Propagate connected user to web app. (Closed)

Created:
9 years, 4 months ago by Jamie

Modified:
9 years, 4 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Propagate connected user to web app. BUG=91047 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95183

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -22 lines)			Patch
M	remoting/host/chromoting_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/heartbeat_sender.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/host/heartbeat_sender.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/host/host_status_observer.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View		5 chunks	+20 lines, -2 lines	1 comment	Download
M	remoting/host/register_support_host_request.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/host/register_support_host_request.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/webapp/me2mom/_locales/en/messages.json	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	remoting/webapp/me2mom/choice.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/webapp/me2mom/l10n.js	View	1	1 chunk	+24 lines, -8 lines	0 comments	Download
M	remoting/webapp/me2mom/remoting.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

For now, please just take a look at the C++ code changes. The rest is ...

9 years, 4 months ago (2011-08-02 00:44:36 UTC) #1

Jamie

On 2011/08/02 00:49:28, Wez wrote: > LGTM If you want to review the web-app changes ...

9 years, 4 months ago (2011-08-02 21:05:59 UTC) #3

Wez

9 years, 4 months ago (2011-08-02 21:38:01 UTC) #4

LGTM

http://codereview.chromium.org/7547001/diff/3001/remoting/host/plugin/host_sc...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/7547001/diff/3001/remoting/host/plugin/host_sc...
remoting/host/plugin/host_script_object.cc:311: LOG(INFO) << "Client " <<
client_username_ << " connected.";
nit: The client has authenticated; they were already connected.

Expand Messages | Collapse Messages