Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/plugin_observer.cc

Issue 7545021: Unify infobars' link-opening behavior to respect user-requested dispositions and append the Googl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_installer_infobar_delegate.cc ('k') | chrome/browser/tab_contents/insecure_content_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_observer.cc
===================================================================
--- chrome/browser/plugin_observer.cc (revision 94544)
+++ chrome/browser/plugin_observer.cc (working copy)
@@ -71,10 +71,10 @@
}
bool PluginInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
- if (disposition == CURRENT_TAB)
- disposition = NEW_FOREGROUND_TAB;
- GURL url = google_util::AppendGoogleLocaleParam(GURL(GetLearnMoreURL()));
- tab_contents_->OpenURL(url, GURL(), disposition, PageTransition::LINK);
+ tab_contents_->OpenURL(
+ google_util::AppendGoogleLocaleParam(GURL(GetLearnMoreURL())), GURL(),
+ (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+ PageTransition::LINK);
return false;
}
« no previous file with comments | « chrome/browser/plugin_installer_infobar_delegate.cc ('k') | chrome/browser/tab_contents/insecure_content_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698