Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/plugin_installer_infobar_delegate.cc

Issue 7545021: Unify infobars' link-opening behavior to respect user-requested dispositions and append the Googl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugin_installer_infobar_delegate.cc
===================================================================
--- chrome/browser/plugin_installer_infobar_delegate.cc (revision 94544)
+++ chrome/browser/plugin_installer_infobar_delegate.cc (working copy)
@@ -4,6 +4,7 @@
#include "chrome/browser/plugin_installer_infobar_delegate.h"
+#include "chrome/browser/google/google_util.h"
#include "content/browser/renderer_host/render_view_host.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/common/view_messages.h"
@@ -58,10 +59,10 @@
bool PluginInstallerInfoBarDelegate::LinkClicked(
WindowOpenDisposition disposition) {
- // Ignore the click dispostion and always open in a new top level tab.
- static const char kLearnMorePluginInstallerUrl[] = "http://www.google.com/"
- "support/chrome/bin/answer.py?answer=95697&topic=14687";
- tab_contents_->OpenURL(GURL(kLearnMorePluginInstallerUrl), GURL(),
- NEW_FOREGROUND_TAB, PageTransition::LINK);
+ tab_contents_->OpenURL(google_util::AppendGoogleLocaleParam(GURL(
+ "http://www.google.com/support/chrome/bin/answer.py?answer=95697&topic="
+ "14687")), GURL(),
+ (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+ PageTransition::LINK);
return false;
}
« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('k') | chrome/browser/plugin_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698