Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

Issue 7545021: Unify infobars' link-opening behavior to respect user-requested dispositions and append the Googl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_geolocation_permission_context.cc
===================================================================
--- chrome/browser/geolocation/chrome_geolocation_permission_context.cc (revision 94544)
+++ chrome/browser/geolocation/chrome_geolocation_permission_context.cc (working copy)
@@ -214,10 +214,10 @@
"https://www.google.com/support/chrome/bin/answer.py?answer=142065";
#endif
- // Ignore the click disposition and always open in a new top level tab.
tab_contents_->OpenURL(
google_util::AppendGoogleLocaleParam(GURL(kGeolocationLearnMoreUrl)),
- GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
+ GURL(), (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+ PageTransition::LINK);
return false; // Do not dismiss the info bar.
}

Powered by Google App Engine
This is Rietveld 408576698