Issue 7545021: Unify infobars' link-opening behavior to respect user-requested dispositions and append the Googl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7545021: Unify infobars' link-opening behavior to respect user-requested dispositions and append the Googl... (Closed)

Created:
9 years, 4 months ago by Peter Kasting

Modified:
9 years, 4 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, jam, Avi (use Gerrit), darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unify infobars' link-opening behavior to respect user-requested dispositions and append the Google locale param (since all these links are opening Google pages). This also fixes an incorrect "&" (should be "&") that I assume is a holdover from the string in question formerly being in generated_resources.grd. Randomly, this also removes some unnecessary .c_str() calls in logging_chrome.cc. BUG=none TEST=Middle-clicking "Learn more" on any applicable infobar should open the link in a new background tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95025

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -18 lines)			Patch
M	chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/plugin_installer_infobar_delegate.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/plugin_observer.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/insecure_content_infobar_delegate.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/logging_chrome.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

LGTM, but I don't see how the & behaviour changed.

9 years, 4 months ago (2011-08-01 22:22:08 UTC) #2

Elliot Glaysher

9 years, 4 months ago (2011-08-01 22:27:48 UTC) #3

On 2011/08/01 22:22:08, Elliot Glaysher wrote:
> LGTM, but I don't see how the &amp; behaviour changed.

I see, thanks Peter.

Expand Messages | Collapse Messages