Implement PPAPI VideoDecode out-of-process support

ppapi/proxy/ppapi_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "base/string16.h"
 #include "base/sync_socket.h"
 #include "gpu/command_buffer/common/command_buffer.h"
 #include "gpu/ipc/gpu_command_buffer_traits.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_message_utils.h"
 #include "ipc/ipc_platform_file.h"
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_file_info.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_module.h"
 #include "ppapi/c/pp_point.h"
 #include "ppapi/c/pp_rect.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/pp_size.h"
+#include "ppapi/c/dev/pp_video_dev.h"
 #include "ppapi/c/private/ppb_flash_tcp_socket.h"
 #include "ppapi/proxy/ppapi_param_traits.h"
 #include "ppapi/proxy/serialized_flash_menu.h"
 #include "ppapi/proxy/serialized_structs.h"
 #include "ppapi/shared_impl/input_event_impl.h"
 #include "ppapi/shared_impl/ppapi_preferences.h"
 
 #define IPC_MESSAGE_START PpapiMsgStart
 
 IPC_ENUM_TRAITS(PP_InputEvent_Type)
@@ skipping 12 matching lines @@
 IPC_STRUCT_TRAITS_BEGIN(PP_Size)
   IPC_STRUCT_TRAITS_MEMBER(height)
   IPC_STRUCT_TRAITS_MEMBER(width)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(PP_Rect)
   IPC_STRUCT_TRAITS_MEMBER(point)
   IPC_STRUCT_TRAITS_MEMBER(size)
 IPC_STRUCT_TRAITS_END()
 
+IPC_STRUCT_TRAITS_BEGIN(PP_PictureBuffer_Dev)
+  IPC_STRUCT_TRAITS_MEMBER(id)
+  IPC_STRUCT_TRAITS_MEMBER(size)
+  IPC_STRUCT_TRAITS_MEMBER(texture_id)
+IPC_STRUCT_TRAITS_END()
+
 IPC_STRUCT_TRAITS_BEGIN(::ppapi::Preferences)
   IPC_STRUCT_TRAITS_MEMBER(standard_font_family)
   IPC_STRUCT_TRAITS_MEMBER(fixed_font_family)
   IPC_STRUCT_TRAITS_MEMBER(serif_font_family)
   IPC_STRUCT_TRAITS_MEMBER(sans_serif_font_family)
   IPC_STRUCT_TRAITS_MEMBER(default_font_size)
   IPC_STRUCT_TRAITS_MEMBER(default_fixed_font_size)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(::ppapi::InputEventData)
@@ skipping 234 matching lines @@
 
 // PPB_URLLoader
 // (Messages from browser to plugin to notify it of changes in state.)
 IPC_MESSAGE_ROUTED1(PpapiMsg_PPBURLLoader_UpdateProgress,
                     pp::proxy::PPBURLLoader_UpdateProgress_Params /* params */)
 IPC_MESSAGE_ROUTED3(PpapiMsg_PPBURLLoader_ReadResponseBody_Ack,
                     pp::proxy::HostResource /* loader */,
                     int32 /* result */,
                     std::string /* data */)
 
+// PPB_VideoDecoder_Dev.
+// (Messages from renderer to plugin to notify it to run callbacks.)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_EndOfBitstreamACK,

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

s/ACK/Callback/g ?
I guess ACK is also used elsewhere in this file, but it seems like a strange
convention to me.  I defer to ppapi folks' judgement.

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

Yeah, I'm not a fan of ACK, either. 

brettw/piman: opinions?

+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

pp_error doesn't name a type.
The only thing I can think of to use here is
/* value from pp_errors.h */

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

I changed it to "error result for callback," a description rather than a type.
(I also plumbed it through the rest of the methods properly; previously I was
dropping the error value and replacing it with PP_OK.)

+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_FlushACK,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_ResetACK,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)
+
+// PPP_VideoDecoder_Dev.
+IPC_MESSAGE_ROUTED3(PpapiMsg_PPPVideoDecoder_ProvidePictureBuffers,
+                    pp::proxy::HostResource /* video_decoder */,
+                    uint32_t /* requested number of buffers */,
+                    PP_Size /* dimensions of buffer */)

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

s/buffer/buffers/

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

Done.

+IPC_MESSAGE_ROUTED2(PpapiMsg_PPPVideoDecoder_DismissPictureBuffer,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture id */)

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

s/picture/picture buffer/
(here and below)

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

Done.

+IPC_MESSAGE_ROUTED3(PpapiMsg_PPPVideoDecoder_PictureReady,

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

Any reason not to pass a PP_Picture_Dev?

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

No. Done!

+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture id */,

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

ditto

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

n/a w/ PP_Picture_Dev.

+                    int32_t /* bitstream id */)

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

s/bitstream/bitstream buffer/

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

n/a w/ PP_Picture_Dev.

+IPC_MESSAGE_ROUTED1(PpapiMsg_PPPVideoDecoder_NotifyEndOfStream,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPPVideoDecoder_NotifyError,
+                    pp::proxy::HostResource /* video_decoder */,
+                    uint32_t /* error id */)

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

PP_VideoDecodeError_Dev ?

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

Done.

+
 // -----------------------------------------------------------------------------
 // These are from the plugin to the renderer.
 
 // Reply to PpapiMsg_CreateChannel. The handle will be NULL if the channel
 // could not be established. This could be because the IPC could not be created
 // for some weird reason, but more likely that the plugin failed to load or
 // initialize properly.
 IPC_MESSAGE_CONTROL1(PpapiHostMsg_ChannelCreated,
                      IPC::ChannelHandle /* handle */)
 
@@ skipping 569 matching lines @@
                            PP_Bool /* is_always_opaque */,
                            pp::proxy::HostResource /* result */)
 IPC_SYNC_MESSAGE_ROUTED4_3(PpapiHostMsg_ResourceCreation_ImageData,
                            PP_Instance /* instance */,
                            int32 /* format */,
                            PP_Size /* size */,
                            PP_Bool /* init_to_zero */,
                            pp::proxy::HostResource /* result_resource */,
                            std::string /* image_data_desc */,
                            pp::proxy::ImageHandle /* result */)
+// PPB_VideoDecoder.
+IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBVideoDecoder_Create,
+                           PP_Instance /* instance */,
+                           pp::proxy::HostResource /* context */,
+                           std::vector<int32_t> /* config */,

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

PP_VideoConfigElement ?

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

Done.

+                           pp::proxy::HostResource /* result */)
+IPC_MESSAGE_ROUTED4(PpapiHostMsg_PPBVideoDecoder_Decode,

[Ami GONE FROM CHROMIUM, 2011/08/02 00:49:08]

Pass PP_VideoBitstreamBuffer_Dev instead?

[vrk (LEFT CHROMIUM), 2011/08/03 19:04:30]

I tried to do this, and I think it makes the plugin crash :) I'm guessing this
isn't quite as simple as the others because PP_VideoBitstreamBuffer_Dev has a
PP_Resource for one of its fields (representing the PP_Buffer). I'm not sure
though. I could try harder.

[Ami GONE FROM CHROMIUM, 2011/08/03 20:25:53]

I think it's worth trying harder not so much because it's a so-much-sexier API,
but because it'd be good to know what the crasher is.

+                    pp::proxy::HostResource /* video_decoder */,
+                    pp::proxy::HostResource /* bitstream buffer */,
+                    int32 /* bitstream buffer id */,
+                    int32 /* size of buffer */)
+IPC_MESSAGE_ROUTED2(PpapiHostMsg_PPBVideoDecoder_AssignPictureBuffers,
+                    pp::proxy::HostResource /* video_decoder */,
+                    std::vector<PP_PictureBuffer_Dev> /* picture buffers */)
+IPC_MESSAGE_ROUTED2(PpapiHostMsg_PPBVideoDecoder_ReusePictureBuffer,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture buffer id */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_PPBVideoDecoder_Flush,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_PPBVideoDecoder_Reset,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_SYNC_MESSAGE_ROUTED1_0(PpapiHostMsg_PPBVideoDecoder_Destroy,
+                           pp::proxy::HostResource /* video_decoder */)