Implement PPAPI VideoDecode out-of-process support

ppapi/proxy/ppapi_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
@@ skipping 294 matching lines @@
 
 // PPB_URLLoader
 // (Messages from browser to plugin to notify it of changes in state.)
 IPC_MESSAGE_ROUTED1(PpapiMsg_PPBURLLoader_UpdateProgress,
                     pp::proxy::PPBURLLoader_UpdateProgress_Params /* params */)
 IPC_MESSAGE_ROUTED3(PpapiMsg_PPBURLLoader_ReadResponseBody_Ack,
                     pp::proxy::HostResource /* loader */,
                     int32 /* result */,
                     std::string /* data */)
 
+// PPB_VideoDecoder_Dev.
+// (Messages from renderer to plugin to notify it to run callbacks.)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_EndOfBitstreamACK,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_FlushACK,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPBVideoDecoder_ResetACK,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* pp_error */)
+
+// PPP_VideoDecoder_Dev.
+IPC_MESSAGE_ROUTED4(PpapiMsg_PPPVideoDecoder_ProvidePictureBuffers,
+                    PP_Instance /* instance */,

[piman, 2011/08/01 20:57:48]

Instance is already encoded in the HostResource, so you don't need to pass it
separately (here and all messages below)

[vrk (LEFT CHROMIUM), 2011/08/01 23:40:04]

Done.

+                    pp::proxy::HostResource /* video_decoder */,
+                    uint32_t /* requested number of buffers */,
+                    PP_Size /* dimensions of buffer */)
+IPC_MESSAGE_ROUTED3(PpapiMsg_PPPVideoDecoder_DismissPictureBuffer,
+                    PP_Instance /* instance */,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture id */)
+IPC_MESSAGE_ROUTED4(PpapiMsg_PPPVideoDecoder_PictureReady,
+                    PP_Instance /* instance */,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture id */,
+                    int32_t /* bitstream id */)
+IPC_MESSAGE_ROUTED2(PpapiMsg_PPPVideoDecoder_NotifyEndOfStream,
+                    PP_Instance /* instance */,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_MESSAGE_ROUTED3(PpapiMsg_PPPVideoDecoder_NotifyError,
+                    PP_Instance /* instance */,
+                    pp::proxy::HostResource /* video_decoder */,
+                    uint32_t /* error id */)
+
 // -----------------------------------------------------------------------------
 // These are from the plugin to the renderer.
 
 // Reply to PpapiMsg_CreateChannel. The handle will be NULL if the channel
 // could not be established. This could be because the IPC could not be created
 // for some weird reason, but more likely that the plugin failed to load or
 // initialize properly.
 IPC_MESSAGE_CONTROL1(PpapiHostMsg_ChannelCreated,
                      IPC::ChannelHandle /* handle */)
 
@@ skipping 569 matching lines @@
                            PP_Bool /* is_always_opaque */,
                            pp::proxy::HostResource /* result */)
 IPC_SYNC_MESSAGE_ROUTED4_3(PpapiHostMsg_ResourceCreation_ImageData,
                            PP_Instance /* instance */,
                            int32 /* format */,
                            PP_Size /* size */,
                            PP_Bool /* init_to_zero */,
                            pp::proxy::HostResource /* result_resource */,
                            std::string /* image_data_desc */,
                            pp::proxy::ImageHandle /* result */)
+// PPB_VideoDecoder.
+IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBVideoDecoder_Create,
+                           PP_Instance /* instance */,
+                           pp::proxy::HostResource /* context */,
+                           std::vector<int32_t> /* config */,
+                           pp::proxy::HostResource /* result */)
+IPC_MESSAGE_ROUTED4(PpapiHostMsg_PPBVideoDecoder_Decode,
+                    pp::proxy::HostResource /* video_decoder */,
+                    pp::proxy::HostResource /* bitstream buffer */,
+                    int32 /* bitstream buffer id */,
+                    int32 /* size of buffer */)
+IPC_MESSAGE_ROUTED4(PpapiHostMsg_PPBVideoDecoder_AssignPictureBuffers,
+                    pp::proxy::HostResource /* video_decoder */,
+                    std::vector<int32_t> /* buffer_ids */,
+                    std::vector<uint32_t> /* texture_ids */,
+                    std::vector<PP_Size> /* buffer sizes */)

[piman, 2011/08/01 20:57:48]

How about a std::vector<PP_PictureBuffer_Dev> instead ? That way you don't need
extra work to verify consistency etc. Logically it's easier to understand too.
Since those are all POD, it should be trivial.

[vrk (LEFT CHROMIUM), 2011/08/01 23:40:04]

Done.

+IPC_MESSAGE_ROUTED2(PpapiHostMsg_PPBVideoDecoder_ReusePictureBuffer,
+                    pp::proxy::HostResource /* video_decoder */,
+                    int32_t /* picture buffer id */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_PPBVideoDecoder_Flush,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_PPBVideoDecoder_Reset,
+                    pp::proxy::HostResource /* video_decoder */)
+IPC_SYNC_MESSAGE_ROUTED1_0(PpapiHostMsg_PPBVideoDecoder_Destroy,

[piman, 2011/08/01 20:57:48]

Does this need to be sync ?

[vrk (LEFT CHROMIUM), 2011/08/01 23:40:04]

Yes, the pepper -> renderer -> gpu path for this message must be synchronous.
The VideoDecoder API guarantees a synchronous Destroy such that after a call to
Destroy, it is safe to delete textures and resources and there will never be any
callbacks to the plugin again. 

+                           pp::proxy::HostResource /* video_decoder */)