Component update (part 6), wire sigleton to browser

Component update part six, wire sigleton to browser

Also adds a minimalistic configurator

TEST=none
BUG=61602
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95336

[cpu_(ooo_6.6-7.5), 2011-08-01 02:07:13]

I might remove the configurator header and just add the factory function on an
existing header.

[asargent_no_longer_on_chrome, 2011-08-02 23:57:07]

LGTM

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/browser_proce...
File chrome/browser/browser_process.h (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/browser_proce...
chrome/browser/browser_process.h:250: #if !defined(OS_CHROMEOS)
So I guess the plan is to not use this on chromeos? Instead of hiding this
behind #ifdef, would it make sense to have it just return null on chromeos?

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/component_upd...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_configurator.cc:84: return
GURL("http://clients2.google.com/service/update2/crx");
I think we have a constant for this somewhere in the extensions code - it might
be good to consolidate. You could save 46 bytes!

http://codereview.chromium.org/7545004/diff/5001/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:144: // Only valid for the browser process.
nit: If you think we'll have this flag long-term, it might be nice to list
possible values here.

[cpu_(ooo_6.6-7.5), 2011-08-03 20:17:12]

thanks. I will commit shortly.

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/browser_proce...
File chrome/browser/browser_process.h (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/browser_proce...
chrome/browser/browser_process.h:250: #if !defined(OS_CHROMEOS)
On 2011/08/02 23:57:07, Antony Sargent wrote:
> So I guess the plan is to not use this on chromeos? Instead of hiding this
> behind #ifdef, would it make sense to have it just return null on chromeos?

Done.

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/component_upd...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_configurator.cc:84: return
GURL("http://clients2.google.com/service/update2/crx");
On 2011/08/02 23:57:07, Antony Sargent wrote:
> I think we have a constant for this somewhere in the extensions code - it
might
> be good to consolidate. You could save 46 bytes! 

I don't think this is going to be the real url. I need it this week to test
though.

http://codereview.chromium.org/7545004/diff/5001/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7545004/diff/5001/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:144: // Only valid for the browser process.
On 2011/08/02 23:57:07, Antony Sargent wrote:
> nit: If you think we'll have this flag long-term, it might be nice to list
> possible values here. 

ok