Issue 7544031: Create AvatarMenuModel for the new avatar menu interface.

Issue 7544031: Create AvatarMenuModel for the new avatar menu interface. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan, sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Create AvatarMenuModel for the new avatar menu interface. This also refactors part of ProfileInfoCache into an abstract interface that is more suitable for testing. BUG=60105 TEST=Partially covered by unit_tests. No UI changes yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95355

Patch Set 1 #

Patch Set 2 : Ready for review #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+463 lines, -7 lines)			Patch
A	chrome/browser/profiles/avatar_menu_model.h	View	1	1 chunk	+105 lines, -0 lines	0 comments	Download
A	chrome/browser/profiles/avatar_menu_model.cc	View	1	1 chunk	+128 lines, -0 lines	0 comments	Download
A	chrome/browser/profiles/avatar_menu_model_observer.h	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/browser/profiles/avatar_menu_model_unittest.cc	View	1	1 chunk	+159 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.h	View	1	2 chunks	+13 lines, -7 lines	0 comments	Download
A	chrome/browser/profiles/profile_info_interface.h	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sail

LGTM I'm not sure if the menu model really needs to observer the profile info ...

9 years, 4 months ago (2011-08-03 22:03:08 UTC) #2

Robert Sesek

On 2011/08/03 22:03:08, sail wrote: > LGTM > > I'm not sure if the menu ...

9 years, 4 months ago (2011-08-03 22:04:55 UTC) #3

sail

9 years, 4 months ago (2011-08-03 22:07:50 UTC) #4

On 2011/08/03 22:04:55, rsesek wrote:
> On 2011/08/03 22:03:08, sail wrote:
> > LGTM
> > 
> > I'm not sure if the menu model really needs to observer the profile info
> cache.
> > The menu is create each time the user clicks on the avatar icon so there's
no
> > danger of it becoming stale.
> 
> Better safe than sorry? What if a profile is being deleted while the user has
> the avatar menu, and then proceeds to click on that profile? Not sure it's
> possible.

Sounds good. (Deleting a profile is actually really simple in that we
synchronously remove it from the ProfileInfoCache.)

Expand Messages | Collapse Messages