chrome/test/pyautolib/download_info.py - Issue 7544026: Fix for flakiness in pyauto automation hook WaitForDownloadsToComplete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/pyautolib/download_info.py

Issue 7544026: Fix for flakiness in pyauto automation hook WaitForDownloadsToComplete. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-wrote the first patch set. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/pyautolib/download_info.py

diff --git a/chrome/test/pyautolib/download_info.py b/chrome/test/pyautolib/download_info.py

index e01fdac69002cfe1cb227f718875d63c8a796420..5f621a2be6721b7217bf8c8291d9c5ce1a002c2c 100644

--- a/chrome/test/pyautolib/download_info.py

+++ b/chrome/test/pyautolib/download_info.py

@@ -10,8 +10,9 @@ Obtain one of these from PyUITestSuite::GetDownloadsInfo() call.

class MyDownloadsTest(pyauto.PyUITest):

def testDownload(self):

- self.NavigateToURL('http://my.url/package.zip')

- self.WaitForDownloadsToComplete()

+ pre_download_ids = [x['id'] for x in self.GetDownloadsInfo().Downloads()]

+ self.DownloadAndWaitForStart('http://my.url/package.zip')

+ self.WaitForAllDownloadsToComplete(pre_download_ids)

info = self.GetDownloadsInfo()

print info.Downloads()

self.assertEqual(info.Downloads()[0]['file_name'], 'packge.zip')